Deregister v2 #18
Deregister v2 #18
Conversation
| private WeakReference<ViewTreeObserver.OnGlobalLayoutListener> mOnGlobalLayoutListenerWeakReference; | ||
|
|
||
| public SimpleDeRegister(Activity activity, ViewTreeObserver.OnGlobalLayoutListener globalLayoutListener){ | ||
| this.mActivityWeakReference = new WeakReference<Activity>(activity); |
| * on 28/02/2017 | ||
| */ | ||
|
|
||
| public interface Deregister { |
There was a problem hiding this comment.
Any reason you prefer deregister over unregister?
I think Android people are more familiar with register - unregister pair than register - deregister(such as Context#registerReceiver and Context#unregisterReceiver).
Also, class/interface name should be noun.
There was a problem hiding this comment.
Even I was using unregister till I read this http://english.stackexchange.com/questions/25931/unregister-vs-deregister
There was a problem hiding this comment.
I think we will go with the common usgea 'unregister'. Will update it with required changes
| @@ -21,7 +21,7 @@ | |||
| * @param activity Activity | |||
| * @param listener KeyboardVisibilityEventListener | |||
| */ | |||
| public static void setEventListener(final Activity activity, | |||
| public static Deregister setEventListener(final Activity activity, | |||
There was a problem hiding this comment.
My bad, to meet the naming consistency, this should be renamed to registerEventListener
|
thanks! will release in a few days after some cleanup :) |
No description provided.