Use libepoxy #1189
Merged
Use libepoxy #1189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## next #1189 +/- ##
==========================================
- Coverage 36.60% 36.21% -0.39%
==========================================
Files 50 50
Lines 11558 11469 -89
==========================================
- Hits 4231 4154 -77
+ Misses 7327 7315 -12
|
yshui
force-pushed
the
libepoxy
branch
8 times, most recently
from
46a5432
to
39af414
Compare
src/backend/gl/egl.c
Outdated
| #define check_ext(name) eglext.has_##name = egl_has_extension(dpy, #name) | ||
| #define check_ext(name) \ | ||
| eglext.has_##name = epoxy_has_egl_extension(dpy, #name); \ | ||
| log_info("Extension %s - %s", #name, eglext.has_##name ? "present" : "absent"); |
There was a problem hiding this comment.
honestly, i don't like the format of this message but i can't think of anything really better right now.
| #define check_ext(name) glxext.has_##name = glx_has_extension(dpy, screen, #name) | ||
| #define check_ext(name) \ | ||
| glxext.has_##name = epoxy_has_glx_extension(dpy, screen, #name); \ | ||
| log_info("Extension " #name " - %s", glxext.has_##name ? "present" : "absent") |
There was a problem hiding this comment.
same as above.
There was a problem hiding this comment.
also, this line is a bit different compared to the one above. let's make them the same at least (don't miss the semicolon at the end!).
There was a problem hiding this comment.
no i need to remove the semicolon on the other line.
yshui
force-pushed
the
libepoxy
branch
2 times, most recently
from
9329112
to
d8e3130
Compare
|
@yshui @absolutelynothelix I'm going to try the changes in OpenBSD, there shouldn't be any problems with using libepoxy, but it's better to clear up any doubts |
Add libepoxy dependency to CI manifest and Nix. For Nix, we need to set shellHook to workaround a NixOS limitation, see: NixOS/nixpkgs#287763 Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
There is actually no specification what symbols are exported from a libGL implementation. The (extremely outdated) OpenGL ABI specification says only GL 1.2 functions are guaranteed. Don't know how relevant that is now, but different libGL implementations do export different set of symbols. On Linux we are most likely to be linked with libglvnd, which has everything we need. But on other platforms this is not necessarily the case, for example on OpenBSD we are missing glGetQueryObjectui64v. Use libepoxy so we can outsource this problem and never worry about it ever again. Plus it also saves us from calling GetProcAddress ourselves. Changes other than trivial build fixes I have to make: 1. Can't use eglCreatePlatformWindowSurface/eglGetPlatformDisplay. libepoxy checks for EGL 1.5 when resolving these functions. But without a current context, libepoxy assumes we only have EGL 1.4. This creates a chicken and egg problem - we need a display to call eglGetPlatformDisplay. We have to use the *EXT version instead. Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
So we don't need maintain our own version. Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
|
@yukiteruamano, we now have an openbsd ci so picom should at least always build there. sorry for the inconvenience! |
|
Yeah, I see that and I test the last changes, compile without issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.