Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing shadow exclude regions list #582

Closed
wants to merge 3 commits into from
Closed

Conversation

ivanmilov
Copy link

My attempt to implement my own change request (#494 (comment))

@@ -0,0 +1,32 @@
name: Check new upstream commits
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to be relevant to this PR?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, my bad. I had had to create another branch for this PR. I thought it is abandoned and pushed mechanism informing me about new commits.
Anyway, what do you think about the changes? Worth merging? Without last commit of course :)

@yshui
Copy link
Owner

yshui commented Mar 29, 2021

I think for what shadow-exclude-reg is intended for, the more ideal replacement option would be shadow-exclude-window, which takes a list of rules, and prevent shadow from being rendered on top of them.

shadow-exclude-reg requires the user to manual get the rectangles, and doesn't allow the windows to move.

@ivanmilov
Copy link
Author

the more ideal replacement option would be shadow-exclude-window

shadow-exclude-window is not implemented, isn't it?

shadow-exclude-reg requires the user to manual get the rectangles, and doesn't allow the windows to move.

I do not get it. My point was to set an array of static regions free from shadow. For example to not shadowing bars.

@ivanmilov
Copy link
Author

Not relevant anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants