Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .gemspec for jekyll 4.0.0 #13

Merged
merged 4 commits into from
Mar 13, 2020
Merged

Update .gemspec for jekyll 4.0.0 #13

merged 4 commits into from
Mar 13, 2020

Conversation

zerobase
Copy link
Contributor

@zerobase zerobase commented Mar 7, 2020

Hi, @ysk24ok. I have updated the gemspec dependency of Jekyll from "~> 3.5" to ">= 3.5" and I confirmed it works well with Jekyll 4.0.0. Thanks.

@ysk24ok
Copy link
Owner

ysk24ok commented Mar 11, 2020

Thank you for this PR, but there is a conflict because #11 is merged.
It would be great if you resolve the conflict.

In addition, how about setting a upper bound, e.x. ">= 3.8.6", "< 4.1" ?
Without upper bound, some users may suffer if new major or minor version such as 5.0.0 or 4.1.0 doesn't work with this plugin properly.
So setting an upper bound of version is a good idea.

@zerobase
Copy link
Contributor Author

@ysk24ok okay, I have installed Appraisal to test this gem with Jekyll 3.5.0 and 4.0.0. Then it is reasonable to set the Jekyll dependency ">= 3.5", "< 4.1" isn't it?

Copy link
Owner

@ysk24ok ysk24ok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appraisal is new to me.
Maybe we can drop support for 3.5-3.7.
Anyway thank you for the PR!

@ysk24ok ysk24ok merged commit ca568ba into ysk24ok:master Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants