-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: boxed preview without an image, for non-OG links #23
Conversation
Thank you for this PR and sorry for the late reply. |
Hey @ysk24ok, |
Thank you for the quick fix, @mostafa . |
You're welcome! 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for the pull request!
Hi @ysk24ok,
I've added a feature to include a boxed preview of the link, just like in Medium, to your library, and done some cleanups.
Usage:
Issue: And found out that some websites block traffic to metainspector, so it fails to fetch data.
Suggestion: it would be good if we cache the images.