Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring #25

Merged
merged 11 commits into from
Oct 26, 2020
Merged

Refactoring #25

merged 11 commits into from
Oct 26, 2020

Conversation

ysk24ok
Copy link
Owner

@ysk24ok ysk24ok commented Oct 26, 2020

  • Let factories create properties objects
    • OpenGraphPropertiesFactory creates OpenGraphProperties
    • NonOpenGraphPropertiesFactory creates NonOpenGraphProperties
  • Let properties objects carry data
  • Added an instruction for testing with Jekyll site
  • Updated README

@ysk24ok ysk24ok merged commit 94597ec into master Oct 26, 2020
@ysk24ok ysk24ok deleted the refactoring branch October 26, 2020 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ysk24ok