Use MetaInspector's best guess on page title when generating Non-OGP preview #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, maybe because the test workflow doesn't have |
This was referenced Jan 28, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #38.
This PR changes the behavior of
NonOpenGraphPropertiesFactoryso that thetitlecan be found even if the page doesn't write its<title>within its<head>. To be specific, one of the following elements will be used as the page title (if more than one is found, the earliest in this list is used:)<meta property='title' ...><meta property='og:title' ...><title>within<head><title>within<body><h1>element within the page