Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken CI #43

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Fix broken CI #43

merged 1 commit into from
Feb 1, 2023

Conversation

ysk24ok
Copy link
Owner

@ysk24ok ysk24ok commented Feb 1, 2023

But this is just a hot fix and it'll break again when the new version of sass-embedded is released, which depends on the newer version of rubygems. If the new version starts to depend on rubygems >= 3.4 which comes with bundler 2.4, this would be a problem as appraisal can't work with bundler 2.4.

There are several alternative solutions:

  • Use jekyll-sass-converter < 3.0. But this is not ideal as we can't keep up with its new versions.
  • Remove appraisal from dependencies of this plugin. As the latest 2.4.1 was released in July 2021, I don't think it's sufficiently maintained. I'd need to look for other libraries to enable testing with several versions of Jekyll. But testing with the latest Jekyll might be sufficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant