Implement a synchronous purge endpoint #711
Conversation
- Added a new API endpoint `POST /deployments/<id>/purge[?force]` - Added a purge command on CLI - Added a PURGE_FAILED deployment status
| } | ||
| if len(errs.Errors) > 0 { | ||
| w.WriteHeader(http.StatusInternalServerError) | ||
| } |
There was a problem hiding this comment.
set the status in case of success ?
} else {
w.WriteHeader(http.StatusOK)
}
There was a problem hiding this comment.
This is not necessary:
// If WriteHeader has not yet been called, Write calls
// WriteHeader(http.StatusOK) before writing the data.
https://pkg.go.dev/net/http#ResponseWriter
There was a problem hiding this comment.
But you are right if we do not set it we do not record it in the telemetry handler
even in nominal mode. In case of error then the deployment status is set to PURGE_FAILED
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed! |
laurentganne
deleted the
feature/GH-707_Add_a_new_synchronous_purge_API_endpoint
branch
Pull Request description
Description of the change
What I did
POST /deployments/<id>/purge[?force]How to verify it
undeployedstatework/deployments/<depid>folder in order to generate an error when purging the deploymentyorc d list) but with an errorwork/deployments/<depid>folderwork/deployments/<depid>folder should not exist anymoreDescription for the changelog
Applicable Issues
Fixes #707