Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 4.1] Checking TOSCA value RawString() to see if property execution_option is defined #749

Merged

Conversation

loicalbertin
Copy link
Member

Pull Request description

Backport of pull request #740 to 4.1

Description of the change

Checking the TOSCA value raw string to find if the SLURM job property execution_options is defined

Description for the changelog

Error submitting a SLURM job with no execution option (GH-739)

Applicable Issues

Fixes #739
Backported from #740

Copy link
Contributor

@laurentganne laurentganne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok!

@sonarcloud
Copy link

sonarcloud bot commented Jun 11, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@loicalbertin loicalbertin merged commit 5d862bb into release/4.1 Jun 11, 2021
@loicalbertin loicalbertin deleted the backport41/bugfix/GH-739-slurm-execution-option branch June 11, 2021 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants