Added basic support for ssh on Windows for raw script execution through Ansible #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ental-windows-target
loicalbertin
approved these changes
Jun 28, 2021
| @@ -876,6 +885,10 @@ func (e *executionCommon) generateHostConnection(ctx context.Context, buffer *by | |||
| if host.port != 0 && host.port != 22 { | |||
| buffer.WriteString(fmt.Sprintf(" ansible_ssh_port=%d", host.port)) | |||
| } | |||
| // Specific ansible connection settings are needed on windows targets | |||
| if strings.Contains(host.osType, "windows") { | |||
There was a problem hiding this comment.
Don't know but maybe it worthwhile to be mentioned somehow in the documentation.
Maybe here https://yorc.readthedocs.io/en/stable/tosca.html#supported-operations-implementations
As it seems to be a very specific behavior.
There was a problem hiding this comment.
Ah yes, proposign to add this:
Basic support for raws scripts execution through Ansible playbooks is also provided on Windows targets configured to use ssh.
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request description
Description of the change
Added the ability to run scripts on Windows through Ansible, having openssh configured on the Windows host as described at https://docs.microsoft.com/en-us/windows-server/administration/openssh/openssh_install_firstuse
What I did
The following modifications were done:
prov/ansible/execution.goAs described in https://docs.ansible.com/ansible/latest/user_guide/windows_setup.html#configuring-ansible-for-ssh-on-windows
to configure Ansible to use SSH for Windows hosts, defining
ansible_connection=sshandansible_shell_type=cmdprov/ansible/execution_ansible.go:The creation/removal of files and drectories is done using
ansible.windows.win_fileon Windowsprov/terraform/commons/resources.go:Updated the default timeout as windows provisionning can take more time than linux distributions
helper/consulutil/consul_ratelimit_publisher.gomisc.: added a logs in daemon in case of failure storing a value
How to verify it
Tested in LEXIS context, in a component running this playbook: https://github.com/lexis-project/application-templates/blob/v0.1.3/weather-climate/components/adms/playbooks/adms_run.yaml
first creating a powershell script from a template
then executing this script
Description for the changelog
Add basic support for ssh on Windows (GH-751)
Applicable Issues
Closes #751