Validate crop config value to avoid runtime error

ysugimoto · Apr 4, 2018 · df9865d · df9865d
1 parent 0302226
commit df9865d
Showing 1 changed file with 14 additions and 0 deletions.
diff --git a/bin/configtest b/bin/configtest
@@ -108,6 +108,7 @@ var reset   = '\u001b[0m';
         validateSize(stdout, resize.size);
         validateFormat(stdout, resize.format);
         validateQuality(stdout, resize.quality);
+        validateCrop(stdout, resize.crop);
         validateOptimizer(stdout, resize.jpegOptimizer || jpegOptimizer);
         validateDestination(stdout, bucket, resize.bucket, resize.directory, resize.template);
         validatePrefixAndSuffix(stdout, resize.prefix, resize.suffix);
@@ -234,4 +235,17 @@ var reset   = '\u001b[0m';
         stdout.write("\r\n");
     }
 
+    function validateCrop(stdout, cropOption) {
+        if ( ! cropOption ) {
+            return;
+        }
+        const cropSpec = /(\d+)x(\d+)([+-]\d+)?([+-]\d+)?(%)?/;
+        if ( ! cropSpec.test(cropOption) ) {
+          fatals.push("Resize crop option is invalid for expected spec: " + cropOption);
+        }
+        stdout.write(magenta + "    Crop:   " + reset);
+        stdout.write(cropOption);
+        stdout.write("\r\n");
+    }
+
 })();