Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: use HHVM 3 #68

Merged
merged 1 commit into from
Sep 15, 2018
Merged

tests: use HHVM 3 #68

merged 1 commit into from
Sep 15, 2018

Conversation

DanielRuf
Copy link
Contributor

Currently testing something.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 68.151% when pulling 79ebc48 on DanielRuf:tests/use-hhvm-3 into 282f783 on yswery:master.

@coveralls
Copy link

coveralls commented Sep 15, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 68.151% when pulling 6c45740 on DanielRuf:tests/use-hhvm-3 into 950adca on yswery:master.

@samuelwilliams
Copy link
Collaborator

Why use HHVM-3 instead of HHVM? The current build of HHVM that travis implements by default is 3.28

@DanielRuf
Copy link
Contributor Author

It is in preparation of the planned end of the PHP support in HHVM 4 being 3.30 the last release with PHP support.

https://hhvm.com/blog/2018/09/12/end-of-php-support-future-of-hack.html

@samuelwilliams samuelwilliams merged commit ecaeeb7 into yswery:master Sep 15, 2018
@DanielRuf DanielRuf deleted the tests/use-hhvm-3 branch September 15, 2018 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DanielRuf @coveralls @samuelwilliams