[ie/orf:on] Support segmented episodes #10053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkf
reviewed
May 29, 2024
dirkf
reviewed
May 29, 2024
| return traverse_obj(api_json, { | ||
| 'id': ('id', {int}, {str_or_none}), | ||
| 'age_limit': ('age_classification', {parse_age_limit}), | ||
| 'duration': ('exact_duration', {functools.partial(float_or_none, scale=1000)}), |
There was a problem hiding this comment.
Surely a sensible set of short names for functools expressions like these can be agreed by now?
There was a problem hiding this comment.
No decision has been made yet. It will be a task of 5 minutes to clean up all instances once a helper method is added.
- Not a segmented episode: return single video - Segmented episode without valid segment id: return entire playlist - Segmented episode with valid segment id and yes-playlist: return entire playlist - Segmented episode with valid segment id and no-playlist: return single video corresponding to segment id In case a multi_video playlist is supposed to be returned, but an unsegmented source exists, that source is chosen instead.
seproDev
changed the title
bashonly
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
Fixes #9930
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?