[ie/soundcloud] Fix download
format extraction
#10125
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original
download
formats are now only available when logged in. This patch adds auth headers to the API request for them and warns when the download formats exist but login is required.Resulting changes:
The redefined
_download_json()
was causing problems with error handling, and it's cleaner/more obvious to just define a_call_api()
method instead.The original download format API call now also counts towards the API rate-limit, so moved the 429 retry loop code into a method so it could be used in multiple places during extraction.EDIT: The original download format API call does not count towards the API rate-limit, so this change was reverted.Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?