Generic extractor overhaul #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pukkandan
force-pushed
the
generic-overhaul
branch
from
d4a615c
to
2f58150
Compare
pukkandan
force-pushed
the
master
branch
2 times, most recently
from
051ec32
to
8a51f56
Compare
pukkandan
force-pushed
the
master
branch
4 times, most recently
from
0429419
to
a392adf
Compare
pukkandan
force-pushed
the
master
branch
2 times, most recently
from
2502e40
to
2305e2e
Compare
pukkandan
force-pushed
the
master
branch
2 times, most recently
from
162dd51
to
da503b7
Compare
|
@einstein95 It has nothing to do with this PR. Please open a new issue |
|
This PR is too large and outdated that it's hopeless to continue from this branch. I'll implement this separately, and in stages |
7 tasks
13 tasks
nswanberg
pushed a commit
to nswanberg/yt-dlp
that referenced
this pull request
Jul 29, 2023
…_in_ch_name hot fix for special chars in channel name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The embed detection in generic extractor is currently a total mess. Each extractor has to explicitly define it's embed detection in generic.py seperately. Many embeds can actually be detected by using functions already in the extractor, but there is no code to automatically do this.
Given how strict the youtube-dl devs are about code maintainability, I have no idea how it got this messed up. Anyhow, I am going to try and clean it up, even if only partially
This PR attempts to:
extract_urlsor similar functions without having to explicitly define their embed detection_VALID_URLStatus: the PR is currently usable though far from being optimal