Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nrk] regression in podcasts #1891

Closed
7 tasks done
barsnick opened this issue Dec 5, 2021 · 2 comments
Closed
7 tasks done

[nrk] regression in podcasts #1891

barsnick opened this issue Dec 5, 2021 · 2 comments
Labels
regression Works in youtube-dl/older yt-dlp site-bug Issue with a specific website

Comments

@barsnick
Copy link
Contributor

barsnick commented Dec 5, 2021

Checklist

Region

worldwide

Description

There's a regression in downloading podcasts using the nrk extractor. This regression was apparently introduced with its latest commit 93c7f33. If I go back to the version prior to this, it works again, see logs below.

I haven't made any effort yet into understanding the commit and checking what else it may have impacted.

Verbose log

[barsnick@moonlight yt-dlp]$ python -m yt_dlp -Uv -F https://radio.nrk.no/podkast/loerdagsraadet/l_73f706bb-736b-41c6-b706-bb736b11c6cc
[debug] Command-line config: ['-Uv', '-F', 'https://radio.nrk.no/podkast/loerdagsraadet/l_73f706bb-736b-41c6-b706-bb736b11c6cc']
[debug] Encodings: locale UTF-8, fs utf-8, out utf-8, err utf-8, pref UTF-8
[debug] yt-dlp version 2021.12.01 [91f071af6] (source)
[debug] Lazy loading extractors is disabled
[debug] Plugins: ['SamplePluginIE', 'SamplePluginPP']
[debug] Git HEAD: aa5ecf082
[debug] Python version 3.10.0 (CPython 64bit) - Linux-5.15.5-200.fc35.x86_64-x86_64-with-glibc2.34
[debug] exe versions: ffmpeg 4.4.1 (setts), ffprobe 4.4.1
[debug] Optional libraries: Cryptodome, mutagen, sqlite, websockets
[debug] Proxy map: {}
Latest version: 2021.12.01, Current version: 2021.12.01
yt-dlp is up to date (2021.12.01)
[debug] [NRKRadioPodkast] Extracting URL: https://radio.nrk.no/podkast/loerdagsraadet/l_73f706bb-736b-41c6-b706-bb736b11c6cc
[debug] Using fake IP 84.214.92.222 (NO) as X-Forwarded-For
[debug] [NRK] Extracting URL: nrk:l_73f706bb-736b-41c6-b706-bb736b11c6cc
[NRK] l_73f706bb-736b-41c6-b706-bb736b11c6cc: Downloading manifest JSON
ERROR: [NRK] l_73f706bb-736b-41c6-b706-bb736b11c6cc: Unable to download JSON metadata: HTTP Error 400: Bad Request (caused by <HTTPError 400: 'Bad Request'>); please report this issue on  https://github.com/yt-dlp/yt-dlp . Make sure you are using the latest version; see  https://github.com/yt-dlp/yt-dlp  on how to update. Be sure to call yt-dlp with the --verbose flag and include its complete output. (caused by <HTTPError 400: 'Bad Request'>); please report this issue on  https://github.com/yt-dlp/yt-dlp . Make sure you are using the latest version; see  https://github.com/yt-dlp/yt-dlp  on how to update. Be sure to call yt-dlp with the --verbose flag and include its complete output.
  File "/home/barsnick/Development/yt-dlp/yt_dlp/extractor/common.py", line 717, in _request_webpage
    return self._downloader.urlopen(url_or_request)
  File "/home/barsnick/Development/yt-dlp/yt_dlp/YoutubeDL.py", line 3387, in urlopen
    return self._opener.open(req, timeout=self._socket_timeout)
  File "/usr/lib64/python3.10/urllib/request.py", line 525, in open
    response = meth(req, response)
  File "/usr/lib64/python3.10/urllib/request.py", line 634, in http_response
    response = self.parent.error(
  File "/usr/lib64/python3.10/urllib/request.py", line 563, in error
    return self._call_chain(*args)
  File "/usr/lib64/python3.10/urllib/request.py", line 496, in _call_chain
    result = func(*args)
  File "/usr/lib64/python3.10/urllib/request.py", line 643, in http_error_default
    raise HTTPError(req.full_url, code, msg, hdrs, fp)

[barsnick@moonlight yt-dlp]$ git revert 93c7f3398dd2e45fdb2c32b49ff169c46eadfbda
[master b9b449fb8] This reverts commit 93c7f3398dd2e45fdb2c32b49ff169c46eadfbda.
 1 file changed, 2 insertions(+), 2 deletions(-)
[barsnick@moonlight yt-dlp]$ python -m yt_dlp -Uv -F https://radio.nrk.no/podkast/loerdagsraadet/l_73f706bb-736b-41c6-b706-bb736b11c6cc
[debug] Command-line config: ['-Uv', '-F', 'https://radio.nrk.no/podkast/loerdagsraadet/l_73f706bb-736b-41c6-b706-bb736b11c6cc']
[debug] Encodings: locale UTF-8, fs utf-8, out utf-8, err utf-8, pref UTF-8
[debug] yt-dlp version 2021.12.01 [91f071af6] (source)
[debug] Lazy loading extractors is disabled
[debug] Plugins: ['SamplePluginIE', 'SamplePluginPP']
[debug] Git HEAD: b9b449fb8
[debug] Python version 3.10.0 (CPython 64bit) - Linux-5.15.5-200.fc35.x86_64-x86_64-with-glibc2.34
[debug] exe versions: ffmpeg 4.4.1 (setts), ffprobe 4.4.1
[debug] Optional libraries: Cryptodome, mutagen, sqlite, websockets
[debug] Proxy map: {}
Latest version: 2021.12.01, Current version: 2021.12.01
yt-dlp is up to date (2021.12.01)
[debug] [NRKRadioPodkast] Extracting URL: https://radio.nrk.no/podkast/loerdagsraadet/l_73f706bb-736b-41c6-b706-bb736b11c6cc
[debug] Using fake IP 84.215.76.22 (NO) as X-Forwarded-For
[debug] [NRK] Extracting URL: nrk:l_73f706bb-736b-41c6-b706-bb736b11c6cc
[NRK] l_73f706bb-736b-41c6-b706-bb736b11c6cc: Downloading manifest JSON
[debug] Formats sorted by: hasvid, ie_pref, lang, quality, res, fps, hdr:12(7), vcodec:vp9.2(10), acodec, filesize, fs_approx, tbr, vbr, abr, asr, proto, vext, aext, hasaud, source, id
[NRK] l_73f706bb-736b-41c6-b706-bb736b11c6cc: Downloading metadata JSON
[info] Available formats for l_73f706bb-736b-41c6-b706-bb736b11c6cc:
ID  EXT │ PROTO │ VCODEC     ACODEC
─────────────────────────────────────
mp3 mp3 │ https │ audio only unknown
@barsnick barsnick added site-bug Issue with a specific website triage Untriaged issue labels Dec 5, 2021
@pukkandan
Copy link
Member

@fractalf Looks like the new EP isnt used by all videos yet. We may need to revert the commit or add fallbacks

@pukkandan pukkandan removed the triage Untriaged issue label Dec 5, 2021
@fractalf
Copy link
Contributor

fractalf commented Dec 5, 2021

@pukkandan I see, yes this might be the best. I should have split this commit also, as it fixes 2 things, and only the url-path change is the issue here. Might look into it later, but for now just revert it

@pukkandan pukkandan added the regression Works in youtube-dl/older yt-dlp label Feb 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression Works in youtube-dl/older yt-dlp site-bug Issue with a specific website
Projects
None yet
Development

No branches or pull requests

3 participants