Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zdf] add support for videos with different ptmd-template location #1893

Merged
merged 2 commits into from
Dec 9, 2021

Conversation

iw0nderhow
Copy link
Contributor

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

This pull request adds support for videos that have their ptmd-template in mainVideoContent...streams.default, like some from FUNK. I have added a test for this kind of URL. No tests are failing, therefore I assume replacing the query instead of adding another is OK.

I have also removed a failing test (the URL currently returns a 410). If this should be in a different PR, please let me know.

@iw0nderhow iw0nderhow force-pushed the fix/zdf branch 2 times, most recently from dce4ea9 to fb5f768 Compare December 5, 2021 15:48
yt_dlp/extractor/zdf.py Outdated Show resolved Hide resolved
@pukkandan pukkandan added site-bug Issue with a specific website pending-fixes PR has had changes requested and removed pending-fixes PR has had changes requested labels Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-bug Issue with a specific website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants