Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make a --really-best-format option #2469

Closed
4 tasks done
philcerf opened this issue Jan 24, 2022 · 9 comments
Closed
4 tasks done

make a --really-best-format option #2469

philcerf opened this issue Jan 24, 2022 · 9 comments
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@philcerf
Copy link

Checklist

Description

The format sorting is documented to have the default:

lang,quality,res,fps,hdr:12,codec:vp9.2,size,br,asr,proto,ext,hasaud,source,id

mentioning that hdr:12 and odec:vp9.2 is set because better ones aren't supported by many devices yet.

That seems rather unfortunate, because people expect that per default they get the "best", while in fact they may not in some cases.

Of course one could just override that with:

--format-sort 'lang,quality,res,fps,hdr,codec,size,br,asr,proto,ext,hasaud,source,id'

which has however the drawback, that it also overrides any extractor specific sort order (which is usually there for a good reason).

So it would be nice to either have something like a --really-best-format option or alternatively, really use the best per default (and perhaps provide a compatibility option that allow people to select formats for older devices.

Cheers.

@philcerf philcerf added enhancement New feature or request triage Untriaged issue labels Jan 24, 2022
@chrizilla
Copy link

related: #2260

@Ashish0804
Copy link
Contributor

or better way is to make best really the best by using av1 and add a --i-use-dlp-on-a-toaster-even-in-2020s option.

@pukkandan
Copy link
Member

#2260 will satisfy this use case and more. There is no need for yet another option

@pukkandan pukkandan added wontfix This will not be worked on and removed triage Untriaged issue labels Jan 24, 2022
@philcerf
Copy link
Author

philcerf commented Jan 24, 2022

@pukkandan But doesn't this again mean that one needs to manually override (and worse, have knowledge about why some extractors override the default and whether this should be actually kept)?

What @Ashish0804 proposes would have been my other choice... I guess it's probably just bad, that the default is not really the best.

@philcerf
Copy link
Author

I went back through git history and it seems at least the restriction to prefer vp9 over av01 dates originally back to 9f88814 which is nearly a year old.
Doesn't most playback software (at least in the Linux world) support AV01 now?

HDR restriction was added with 176f186

@pukkandan
Copy link
Member

#458 (comment)

The HDR restriction makes sense to use permanently. While DV is technically better than the other formats, it is terrible if your display does not support it. So I want users to specifically ask for it if they want to prioritize it

@Jules-A
Copy link
Contributor

Jules-A commented Jan 24, 2022

@philcerf Even if most people could play AV1, Youtube (practically the only site that's serving it) aim for AV1 to have the same quality as the VP9 encode with the advantage only being the file size savings from using a lower bitrate which is more useful for streaming than downloading with YT-DLP.

@0xallie
Copy link
Contributor

0xallie commented Jan 24, 2022

#458 (comment)

The HDR restriction makes sense to use permanently. While DV is technically better than the other formats, it is terrible if your display does not support it. So I want users to specifically ask for it if they want to prioritize it

Yeah, DV is a proprietary format. But dual-layer HDR10+DV streams (DV profile 8) should probably be prioritized over HDR10-only.

@chrizilla
Copy link

chrizilla commented Apr 6, 2023

with the advantage only being the file size savings from using a lower bitrate which is more useful for streaming than downloading with YT-DLP.

Same quality for half (or considerable reduction of) the file size is useful for both streaming and downloading. One could argue that filesize is even more important for downloading given that you have to store the downloaded video on a limited storage space.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

5 participants