Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Man page: Clarify behavior of --check-formats #3309

Closed
wants to merge 2 commits into from
Closed

Man page: Clarify behavior of --check-formats #3309

wants to merge 2 commits into from

Conversation

danielyli
Copy link
Contributor

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement — documentation
  • New extractor
  • New feature

Description of your pull request and other information

It looks like --check-formats attempts to download the next best format if the server 503s on the best one. This PR clarifies this behavior in the manpage.

Related: #3308

@pukkandan
Copy link
Member

It doesn't help with just "best" selection, but also with -f f1/f2/f3. How about this:

Make sure formats are selected only from those that are actually downloadable

@pukkandan pukkandan added the docs/meta/cleanup related to docs, code cleanup, templates, devscripts etc label Apr 5, 2022
@danielyli
Copy link
Contributor Author

I like that :) Updated.

@danielyli
Copy link
Contributor Author

What’s remaining for this PR to be merged?

pukkandan added a commit that referenced this pull request Apr 8, 2022
@pukkandan @danielyli @cffswb
[docs] Minor improvements (#3309, #3343)
ebc7d3f 
Authored by: cffswb, danielyli


Co-authored-by: Daniel Li <dan@danielyli.com>
Co-authored-by: cffswb <karte577@gmail.com>
@pukkandan
Copy link
Member

ebc7d3f

@pukkandan pukkandan closed this Apr 8, 2022
@danielyli danielyli deleted the check-formats-documentation branch April 8, 2022 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docs/meta/cleanup related to docs, code cleanup, templates, devscripts etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danielyli @pukkandan