Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use project one name, not two different ones #34

Closed
axcore opened this issue Jan 25, 2021 · 12 comments
Closed

Use project one name, not two different ones #34

axcore opened this issue Jan 25, 2021 · 12 comments
Labels
PR-needed Features that maintainers will not work on; but PRs are welcome

Comments

@axcore
Copy link

axcore commented Jan 25, 2021

Checklist

  • [x ] I'm reporting a feature request
  • [x ] I've verified that I'm running yt-dlp version 2021.01.24
  • [x ] I've searched the bugtracker for similar feature requests including closed ones

Description

Tartube is a GUI front-end for youtube-dl, youtube-dlc and other compatible downloaders.

At the moment, Tartube is not compatible with yt-dlp because the latter is using two different names. On PyPI your project is called yt-dlp, but the binary is still called youtube-dlc. Tartube assumes that both names are the same (and so will everything else).

So, my features request is to choose just one name.

@pukkandan
Copy link
Member

pukkandan commented Jan 25, 2021

When I changed the project name to yt-dlp, there were a few reasons I decided to keep the binary and module name as youtube-dlc. Most of them are small things, but the main reason is that it is honestly quite a bit of work to change it everywhere without messing anything up, while there are almost no benefits in doing so.

It is probably easier to change tartube's code to allow for different package and binary names. But, if instead, you or anyone else wants to make a PR here with the necessary changes, I'd be glad to merge it.

@candrapersada
Copy link

or use Releases · pukkandan_yt-dlp for a while
image

@axcore
Copy link
Author

axcore commented Jan 26, 2021

but the main reason is that it is honestly quite a bit of work to change it everywhere without messing anything up

How would you feel about using the name youtube-dlp? blackjack4494 has already done the hard work of converting youtube-dl to youtube-dlc throughout the code, but only where necessary. So, in theory, we only need to update that subset of changes.

Anyway, I'm happy to do the PR, so you can decide for yourself whether it's worth merging or not, I just need your preferred choice of name.

@pukkandan
Copy link
Member

pukkandan commented Jan 26, 2021

Anyway, I'm happy to do the PR

Thanks

you can decide for yourself whether it's worth merging or not

If you make the PR, I'll definitely merge it. I just dont wanna put in the effort

I just need your preferred choice of name.

yt-dlp since it's the repo name and I'm already using it as pypi package name

@pukkandan
Copy link
Member

I just saw this: axcore/tartube#254, which I assume is the reason you opened this issue here.

I would actually suggest you give an option in tartube to choose the package name and binary name separately. This will allow your users to install any fork using the git+https://github.com/pukkandan/yt-dlp.git@release even if the fork they want to use has no pypi package

@axcore
Copy link
Author

axcore commented Jan 27, 2021

As far as I can tell, not practical.

Consider this situation: the user installs youtube-dlc, then later installs yt-dlp. Later they decide to switch back to youtube-dlc (from Tartube, or from the command line). Only someone who has examine the source code knows that the earlier installation has been overwritten.

Now the user tries to uninstall youtube-dlc. Suddenly yt-dlp doesn't work any more, because yt-dlp's executable has been removed.

@pukkandan
Copy link
Member

I understand. While I can think of ways to workaround this problem, I can see how this could be annoying, especially to non tech-savy users

@candrapersada
Copy link

tartube can use the yt-dlp custom path by using
python3 Downloads/youtube-dlc https://www.youtube.com/watch?v=CG8CX5mx2mk or python3 /home/user/Downloads/youtube-dl https://www.youtube.com/watch?v=CG8CX5mx2mk without without installing the yt-dlp package to pypi
image
image

@axcore
Copy link
Author

axcore commented Jan 27, 2021

Yes, but I will remove that soon, for the reasons above.

@pukkandan
Copy link
Member

The module name has been completely changed to yt-dlp

@candrapersada
Copy link

candrapersada commented Feb 24, 2021

how to remove file youtube-dlc from pip3?

@pukkandan
Copy link
Member

If you just want to overwrite it with youtube-dlc, use pip3 install youtube-dlc

Or uninstall and reinstall yt-dlp

pip3 uninstall yt-dlp
pip3 install yt-dlp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-needed Features that maintainers will not work on; but PRs are welcome
Projects
None yet
Development

No branches or pull requests

3 participants