-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use project one name, not two different ones #34
Comments
When I changed the project name to yt-dlp, there were a few reasons I decided to keep the binary and module name as youtube-dlc. Most of them are small things, but the main reason is that it is honestly quite a bit of work to change it everywhere without messing anything up, while there are almost no benefits in doing so. It is probably easier to change tartube's code to allow for different package and binary names. But, if instead, you or anyone else wants to make a PR here with the necessary changes, I'd be glad to merge it. |
or use Releases · pukkandan_yt-dlp for a while |
How would you feel about using the name Anyway, I'm happy to do the PR, so you can decide for yourself whether it's worth merging or not, I just need your preferred choice of name. |
Thanks
If you make the PR, I'll definitely merge it. I just dont wanna put in the effort
|
I just saw this: axcore/tartube#254, which I assume is the reason you opened this issue here. I would actually suggest you give an option in tartube to choose the package name and binary name separately. This will allow your users to install any fork using the |
As far as I can tell, not practical. Consider this situation: the user installs youtube-dlc, then later installs yt-dlp. Later they decide to switch back to youtube-dlc (from Tartube, or from the command line). Only someone who has examine the source code knows that the earlier installation has been overwritten. Now the user tries to uninstall youtube-dlc. Suddenly yt-dlp doesn't work any more, because yt-dlp's executable has been removed. |
I understand. While I can think of ways to workaround this problem, I can see how this could be annoying, especially to non tech-savy users |
Yes, but I will remove that soon, for the reasons above. |
The module name has been completely changed to yt-dlp |
how to remove file youtube-dlc from pip3? |
If you just want to overwrite it with youtube-dlc, use Or uninstall and reinstall yt-dlp
|
Checklist
Description
Tartube is a GUI front-end for youtube-dl, youtube-dlc and other compatible downloaders.
At the moment, Tartube is not compatible with yt-dlp because the latter is using two different names. On PyPI your project is called yt-dlp, but the binary is still called youtube-dlc. Tartube assumes that both names are the same (and so will everything else).
So, my features request is to choose just one name.
The text was updated successfully, but these errors were encountered: