Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[facebook] Update extractor for new URL #3824

Merged
merged 6 commits into from Jan 18, 2024
Merged

[facebook] Update extractor for new URL #3824

merged 6 commits into from Jan 18, 2024

Conversation

Wikidepia
Copy link
Contributor

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Description of your pull request and other information

Close #3496

Tested URLs:

@Ashish0804
Copy link
Contributor

Add the new urls to matching only test atleast.
Also baste username.

@pukkandan pukkandan added site-bug Issue with a specific website pending-fixes PR has had changes requested labels May 27, 2022
@pukkandan pukkandan added the stale-pr PR that has been pending fixes for a long time label Aug 8, 2022
@ivanskodje ivanskodje mentioned this pull request May 22, 2023
Closed
7 tasks
@pukkandan pukkandan force-pushed the master branch 2 times, most recently from ee280c7 to 7aeda6c Compare May 24, 2023 18:09
kclauhk added a commit to kclauhk/yt-dlp that referenced this pull request Dec 23, 2023
@kclauhk
Update extractor for new URL yt-dlp#3824
6bc4e1e 
Fixes yt-dlp#3496
Close yt-dlp#3824
@kclauhk kclauhk mentioned this pull request Dec 23, 2023
Merged
9 tasks
seproDev added a commit to kclauhk/yt-dlp that referenced this pull request Dec 24, 2023
@seproDev
Revert "Update extractor for new URL yt-dlp#3824"
7ec3928 
This reverts commit 6bc4e1e.
@seproDev seproDev added pending-review PR needs a review and removed stale-pr PR that has been pending fixes for a long time pending-fixes PR has had changes requested labels Dec 24, 2023
@bashonly bashonly added do-not-merge and removed pending-review PR needs a review labels Jan 18, 2024
@seproDev seproDev merged commit cf9af2c into yt-dlp:master Jan 18, 2024
6 checks passed
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
@Wikidepia @kclauhk @aalsuwaidi
[ie/Facebook] Add new ID format (yt-dlp#3824)
7c2ef3b 
Closes yt-dlp#3496
Authored by: Wikidepia, kclauhk

Co-authored-by: kclauhk <78251477+kclauhk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bashonly bashonly bashonly approved these changes

Assignees

@seproDev seproDev

Labels
site-bug Issue with a specific website
Projects
Major sites
Status: facebook
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Facebook] New URL doesn't work
6 participants
@Wikidepia @Ashish0804 @bashonly @seproDev @pukkandan @kclauhk