Update tv5mondeplus.py to detect subtitles #4209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yt-dlp#4205 extract subtitle URL for TV5MONDE.
pukkandan
requested changes
Jun 28, 2022
|
confirm evevrything's still working |
pukkandan
added
site-enhancement
pukkandan
reviewed
Jun 28, 2022
pukkandan
force-pushed
the
master
branch
2 times, most recently
from
ee280c7
to
7aeda6c
Compare
|
Can confirm still works |
seproDev
added
pending-review
bashonly
approved these changes
Nov 15, 2023
aalsuwaidi
pushed a commit
to aalsuwaidi/yt-dlp
that referenced
this pull request
Apr 21, 2024
Closes yt-dlp#4205 Authored by: FrankZ85
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Fixes #4205
This retrieves the subtitles as announced by the streaming site. The code to iterate over the subtitle definitions is taken from other extractors.
It would still be nice to try and detect the other, not announced, subtitles. Maybe by sending HEAD requests to the guessed URLs to get the HTTP status? For this entry, replacing the second "FRA" by "DEU", "ENG", "SPA" worked just fine.