Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playlist Description Character Limit #47

Closed
3 tasks done
undaunt opened this issue Feb 1, 2021 · 6 comments
Closed
3 tasks done

Playlist Description Character Limit #47

undaunt opened this issue Feb 1, 2021 · 6 comments
Labels
bug Bug that is not site-specific

Comments

@undaunt
Copy link

undaunt commented Feb 1, 2021

Checklist

  • I'm asking a question
  • I've looked through the README and FAQ for similar questions
  • I've searched the bugtracker for similar questions including closed ones

Question

Is there a character limit on the playlist specific JSON file for the description field? I'm wondering because long descriptions from episode files appear to be created fine, such as if I open the episode 1 JSON for this playlist:

PLz3Be--ot61Mvmms68yBEhX6KrzPrqxsW

"Troy Lavallee and Matthew Capodicasa of The Glass Cannon Network sit down to talk about Matthew's upcoming character in their soon to be released #StarfinderRPG #DeadSuns podcast - Androids & Aliens!\n\nhttp://www.glasscannonpodcast.com"

However. if I open the channel's playlist JSON (which appears to be downloaded in the same way as the playlist JSON, except the 'uploader' is null) the description field is cut off with an ellipsis.

It should be:

In the spirit of old school Dungeons and Dragons, a collection of five super-nerds (Joe O'Brien, Grant Berger, Matthew Capodicasa, Skid Maher, and Gamemaster Troy Lavallee) emerge blinking from their parents' basements to engage in an Actual Play campaign of Paizo's epic new adventure path, Giantslayer! Foes will be vanquished, beers will be dranken, and characters will almost certainly f**cking die.

Now you can watch these same idiots play video games on this YouTube channel!

Become a supporter of the podcast at our Patreon page: http://www.patreon.com/glasscannon
You can help us unlock goals for the future while unlocking fun GCP exclusive rewards for yourself!

but is cut off after "Gamemaster" as shown below in the channel playlist. Additional json's for reference.

Channel Playlist

{
  "_type": "playlist",
  "id": "TheGlassCannon",
  "title": "The Glass Cannon Network",
  "description": "In the spirit of old school Dungeons and Dragons, a collection of five super-nerds (Joe O'Brien, Grant Berger, Matthew Capodicasa, Skid Maher, and Gamemaster...",
  "extractor": "youtube:tab",
  "webpage_url": "https://www.youtube.com/TheGlassCannon/playlists",
  "duration_string": null,
  "webpage_url_basename": "playlists",
  "extractor_key": "YoutubeTab"
}

Regular Playlist

{
  "_type": "playlist",
  "id": "PLz3Be--ot61Mvmms68yBEhX6KrzPrqxsW",
  "title": "Dead Suns Character Intros",
  "uploader": "The Glass Cannon Network",
  "uploader_id": "UC83CJFLyDe72XgkKBd5a9IA",
  "uploader_url": "https://www.youtube.com/c/TheGlassCannon",
  "extractor": "youtube:tab",
  "webpage_url": "https://www.youtube.com/playlist?list=PLz3Be--ot61Mvmms68yBEhX6KrzPrqxsW",
  "duration_string": null,
  "webpage_url_basename": "playlist",
  "extractor_key": "YoutubeTab"
}

Snippet of episode 1 from playlist

{
  "id": "tO68f7aiwOA",
  "uploader": "The Glass Cannon Network",
  "uploader_id": "UC83CJFLyDe72XgkKBd5a9IA",
  "uploader_url": "http://www.youtube.com/channel/UC83CJFLyDe72XgkKBd5a9IA",
  "channel_id": "UC83CJFLyDe72XgkKBd5a9IA",
  "channel_url": "http://www.youtube.com/channel/UC83CJFLyDe72XgkKBd5a9IA",
  "upload_date": "20180418",
  "license": null,
  "creator": null,
  "title": "Dead Suns Character Introduction with Troy and Matthew",
  "alt_title": null,
  "description": "Troy Lavallee and Matthew Capodicasa of The Glass Cannon Network sit down to talk about Matthew's upcoming character in their soon to be released #StarfinderRPG #DeadSuns podcast - Androids & Aliens!\n\nhttp://www.glasscannonpodcast.com",
@undaunt undaunt added the question Question label Feb 1, 2021
@pukkandan
Copy link
Member

I am trying to expand the playlist metadata ro contain more fields such as thumbnail, likes etc. I will check if it is possible to fix this and #48 when I work on that.

@pukkandan pukkandan added bug Bug that is not site-specific and removed question Question labels Feb 2, 2021
@pukkandan pukkandan changed the title JSON field "description" Character Limit Playlist Description Character Limit Feb 2, 2021
@pukkandan
Copy link
Member

Check out the latest master.

The thumbnail extraction for playlists will sometimes fail, but honestly, I am not very interested in fixing it

Playlist

{
  "_type": "playlist",
  "uploader": "pukkandan",
  "uploader_id": "UCKcqXmCcyqnhgpA5P0oHH_Q",
  "uploader_url": "https://www.youtube.com/channel/UCKcqXmCcyqnhgpA5P0oHH_Q",
  "thumbnails": [
    {
      "url": "https://i.ytimg.com/img/no_thumbnail.jpg",
      "width": 120,
      "height": 90
    },
    {
      "url": "https://i.ytimg.com/img/no_thumbnail.jpg",
      "width": 320,
      "height": 180
    },
    {
      "url": "https://i.ytimg.com/img/no_thumbnail.jpg",
      "width": 480,
      "height": 360
    }
  ],
  "tags": [],
  "channel": "pukkandan",
  "channel_id": "UCKcqXmCcyqnhgpA5P0oHH_Q",
  "channel_url": "https://www.youtube.com/channel/UCKcqXmCcyqnhgpA5P0oHH_Q",
  "id": "PLx-_-Kk4c89rJQdvDiI_EOstdo4Os4Zjh",
  "title": "test",
  "description": "Empty playlist with very long description for testing yt-dlp. \n\nqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwertyqwerty\n\nDONE",
  "extractor": "youtube:tab",
  "webpage_url": "https://www.youtube.com/playlist?list=PLx-_-Kk4c89rJQdvDiI_EOstdo4Os4Zjh",
  "duration_string": null,  // Will be removed by PR #45
  "webpage_url_basename": "playlist",
  "extractor_key": "YoutubeTab"
}

Channel

{
  "_type": "playlist",
  "uploader": "The Glass Cannon Network",
  "uploader_id": "UC83CJFLyDe72XgkKBd5a9IA",
  "uploader_url": "https://www.youtube.com/channel/UC83CJFLyDe72XgkKBd5a9IA",
  "thumbnails": [
    {
      "url": "https://yt3.ggpht.com/ytc/AAUvwnhPOln7N6iokDhmfJV_ok_ahFZJ0FX-uCDgf5i_lg=s900-c-k-c0x00ffffff-no-rj",
      "width": 900,
      "height": 900
    }
  ],
  "tags": [
    "pathfinderrpg",
    "starfinderrpg",
    "dnd",
    "dungeonsanddragons",
    "dandd",
    "tabletoprpg",
    "ttrpg",
    "troylavallee",
    "joeobrien",
    "skidmaher",
    "grantberger",
    "matthewcapodicasa"
  ],
  "channel": "The Glass Cannon Network",
  "channel_id": "UC83CJFLyDe72XgkKBd5a9IA",
  "channel_url": "https://www.youtube.com/channel/UC83CJFLyDe72XgkKBd5a9IA",
  "id": "UC83CJFLyDe72XgkKBd5a9IA",
  "title": "The Glass Cannon Network - Playlists",
  "description": "In the spirit of old school Dungeons and Dragons, a collection of five super-nerds (Joe O'Brien, Grant Berger, Matthew Capodicasa, Skid Maher, and Gamemaster Troy Lavallee) emerge blinking from their parents' basements to engage in an Actual Play campaign of Paizo's epic new adventure path, Giantslayer! Foes will be vanquished, beers will be dranken, and characters will almost certainly f**cking die.\n\nNow you can watch these same idiots play video games on this YouTube channel!\n\nBecome a supporter of the podcast at our Patreon page: http://www.patreon.com/glasscannon\nYou can help us unlock goals for the future while unlocking fun GCP exclusive rewards for yourself!",
  "extractor": "youtube:tab",
  "webpage_url": "https://www.youtube.com/channel/UC83CJFLyDe72XgkKBd5a9IA/playlists",
  "duration_string": null, // Will be removed by PR #45
  "webpage_url_basename": "playlists",
  "extractor_key": "YoutubeTab"
}

@undaunt
Copy link
Author

undaunt commented Feb 2, 2021

I'm checking this out right now, looks awesome. I'm looking at episode/playlist/channel level JSONs from a playlist URL call and episode/channel from a channel URL call. One thing that jumped out right out of the gate is episode 001's JSON file pulls some crazy format information and created a 943KB file.

EDIT: Must just be a weird episode, disregard. Will continue to test.

@pukkandan
Copy link
Member

pukkandan commented Feb 2, 2021

I haven't touched video metadata (except adding back the channel field which has been broken for a while). So the huge format information is not related to this patch. The patch focuses on playlist/channel data

@pukkandan
Copy link
Member

Close the issues once you have confirmed all data is being extracted correctly

@undaunt
Copy link
Author

undaunt commented Feb 2, 2021

Length looks great!

@undaunt undaunt closed this as completed Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug that is not site-specific
Projects
None yet
Development

No branches or pull requests

2 participants