Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extractor/niconico] Add support for like history #5705

Merged
merged 3 commits into from
Feb 3, 2023

Conversation

Matumo
Copy link
Contributor

@Matumo Matumo commented Dec 4, 2022

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

This adds support for like history.

Like history URLs have the same prefix as watch history URLs. Therefore, I fixed the regular expression of NiconicoHistoryIE (watch history extractor). Specifically, URLs with like after history/ are excluded.

Fixes #

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Copy link
Member

@pukkandan pukkandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole extractor is redundant and could be easily merged into NiconicoHistoryIE. Alternately, create a base class to subclass both from

@pukkandan pukkandan added pending-fixes PR has had changes requested site-enhancement Feature request for some website labels Dec 4, 2022
@Matumo
Copy link
Contributor Author

Matumo commented Dec 5, 2022

Thank you. I created a base class.

@pukkandan pukkandan removed the pending-fixes PR has had changes requested label Dec 16, 2022
@pukkandan
Copy link
Member

Though I suggested subclassing as an option, it's clear looking at final code that there is no point in it being a new class

@pukkandan
Copy link
Member

pls test and let me know

@pukkandan pukkandan added the needs-testing Patch needs testing label Dec 29, 2022
@Matumo
Copy link
Contributor Author

Matumo commented Jan 19, 2023

I agree with you. I added IE only for checking the regular expression's correctness using the URL match test.
I tested it using my account. The code works correctly.

@pukkandan pukkandan removed the needs-testing Patch needs testing label Jan 19, 2023
@pukkandan pukkandan merged commit 3b16126 into yt-dlp:master Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-enhancement Feature request for some website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants