Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extractor/niconico:live] Add extractor #5764

Merged
merged 5 commits into from May 29, 2023

Conversation

Lesmiscore
Copy link
Contributor

@Lesmiscore Lesmiscore commented Dec 10, 2022

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Closes #367 (except the GPL part we're not allowed to copy into our tree)

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

@Lesmiscore Lesmiscore marked this pull request as draft December 10, 2022 14:15
it was easy than my expectation
@Lesmiscore Lesmiscore marked this pull request as ready for review December 10, 2022 14:35
@pukkandan pukkandan added enhancement New feature or request site-request Request to support a new website labels Dec 10, 2022
@pukkandan pukkandan force-pushed the master branch 2 times, most recently from ee280c7 to 7aeda6c Compare May 24, 2023 18:09
@pukkandan
Copy link
Member

I wanted to implement the new custom downloader framework first, but since that's going nowhere, you can merge this for now

@Lesmiscore Lesmiscore merged commit f8f9250 into yt-dlp:master May 29, 2023
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request site-request Request to support a new website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Niconico] Merging niconico extractor from animelover1984/youtube-dl
2 participants