Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time based options readme is misleading. #5774

Closed
9 tasks done
Shituation opened this issue Dec 11, 2022 · 4 comments
Closed
9 tasks done

Time based options readme is misleading. #5774

Shituation opened this issue Dec 11, 2022 · 4 comments
Assignees
Labels
docs/meta/cleanup related to docs, code cleanup, templates, devscripts etc

Comments

@Shituation
Copy link

Shituation commented Dec 11, 2022

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

  • I understand that I will be blocked if I remove or skip any mandatory* field

Checklist

  • I'm reporting a bug unrelated to a specific site
  • I've verified that I'm running yt-dlp version 2022.11.11 (update instructions) or later (specify commit)
  • I've checked that all provided URLs are playable in a browser with the same IP and same login details
  • I've checked that all URLs and arguments with special characters are properly quoted or escaped
  • I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
  • I've read the guidelines for opening an issue

Provide a description that is worded well enough to be understood

This is in the readme:

--date DATE                     Download only videos uploaded on this date.
                                The date can be "YYYYMMDD" or in the format 
                                [now|today|yesterday][-N[day|week|month|year]].
                                E.g. --date today-2weeks

This is real life:
2

The readme should explain a little more what this option does exactly. By reading the actual readme, I thought --date today-2weeks was a range <<today and all videos until 2 weeks back in time>> its misleading. Readme should make explicit that we are not talking about ranges here. The example --date today-2weeks is misleading since people can think its a range and not actually "video from today and a video from exactly 2 weeks back ( - 14 days backwards).

Provide verbose output that clearly demonstrates the problem

  • Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
  • Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output

C:\Youtube-dlp>"C:\Youtube-dlp\yt-dlp.exe" -vU -x -4 --external-downloader aria2c --playlist-end 10 --restrict-filenames --match-filter "title*='XXXXXXXXXXXXXX'" --date today-2weeks --audio-format mp3 -o "E:\XXXXXXXXX\XXXXXXXXX\%(title)s.%(ext)s" "https://www.youtube.com/c/XXXXXXXXXXXXXX/videos"
[debug] Command-line config: ['-vU', '-x', '-4', '--external-downloader', 'aria2c', '--playlist-end', '10', '--restrict-filenames', '--match-filter', "title*='XXXXXXXXXXXXX'", '--date', 'today-2weeks', '--audio-format', 'mp3', '-o', 'E:\\XXXXXXXXXXX\\XXXXXX\\%(title)s.%(ext)s', 'https://www.youtube.com/c/XXXXXXXXXXXXX/videos']
[debug] Encodings: locale cp1252, fs utf-8, pref cp1252, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version 2022.11.11 [8b64402] (win_exe)
[debug] Python 3.8.10 (CPython AMD64 64bit) - Windows-10-10.0.19044-SP0 (OpenSSL 1.1.1k  25 Mar 2021)
[debug] exe versions: ffmpeg 4.3.1-2020-11-08-full_build-www.gyan.dev, ffprobe 4.3.1-2020-11-08-full_build-www.gyan.dev
[debug] Optional libraries: Cryptodome-3.15.0, brotli-1.0.9, certifi-2022.09.24, mutagen-1.46.0, sqlite3-2.6.0, websockets-10.4
[debug] Proxy map: {}
[debug] Loaded 1723 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Latest version: 2022.11.11, Current version: 2022.11.11
yt-dlp is up to date (2022.11.11)
[debug] [youtube:tab] Extracting URL: https://www.youtube.com/c/XXXXXXXXX/videos
[youtube:tab] XXXXXXXXXX/videos: Downloading webpage
[debug] [youtube:tab] Selected tab: 'videos' (videos), Requested tab: 'videos'
[download] Downloading playlist: XXXXXXXXXXXXXXX - Videos
[youtube:tab] Playlist XXXXXXXXXXXXX - Videos: Downloading 10 videos
[download] Downloading video 1 of 10
[debug] [youtube] Extracting URL: https://www.youtube.com/XXXXXXXXXXXXXXX
[youtube] e1BgbhVjo6Y: Downloading webpage
[youtube] e1BgbhVjo6Y: Downloading android player API JSON
[debug] Sort order given by extractor: quality, res, fps, hdr:12, source, vcodec:vp9.2, channels, acodec, lang, proto
[debug] Formats sorted by: hasvid, ie_pref, quality, res, fps, hdr:12(7), source, vcodec:vp9.2(10), channels, acodec, lang, proto, filesize, fs_approx, tbr, vbr, abr, asr, vext, aext, hasaud, id
[download] 2022-12-08 upload date is not in range 2022-11-27 - 2022-11-27
@Shituation Shituation added bug Bug that is not site-specific triage Untriaged issue labels Dec 11, 2022
@Shituation Shituation changed the title Time based options doesn't recognize example from readme Time based options readme is misleading. Dec 11, 2022
@pukkandan pukkandan added docs/meta/cleanup related to docs, code cleanup, templates, devscripts etc and removed bug Bug that is not site-specific triage Untriaged issue labels Dec 11, 2022
@pukkandan
Copy link
Member

Any specific suggestions for the wording?

@Shituation
Copy link
Author

Shituation commented Dec 11, 2022

--date DATE                     Download only videos uploaded on this date exactly.
                                        Not a range format.
                                        The date can be "YYYYMMDD" or in the format: 
                                        [now|today|yesterday][-N[day|week|month|year]]. 
                                        E.g. --date today-2weeks  This will download a video from 2 weeks 
                                                                  ago, counting back 14 days since today.
                                        Note this will not download all videos from the last 2 weeks.

Change whatever I may be wrong, this is just a suggestion.

@pukkandan
Copy link
Member

The formatting is not manually controlled, but auto-generated. Only the text can be changed

How about

    --date DATE                     Download only videos uploaded on this single date.
                                    The date can be "YYYYMMDD" or in the format 
                                    [now|today|yesterday][-N[day|week|month|year]].
                                    E.g. --date today-2weeks downloads only
                                    videos uploaded on the same day two weeks ago

@Shituation
Copy link
Author

Looks good but I would insist on being explicit about not being a range because thats what I thought all this time and just found out when I needed to change my script. Sometimes its better to explain like to a 5yo, you know many people from around the world comes here and the language is a barrier too.

    --date DATE                     Download only videos uploaded on this single date. 
                                    Not a range.
                                    The date can be "YYYYMMDD" or in the format 
                                    [now|today|yesterday][-N[day|week|month|year]].
                                    E.g. --date today-2weeks downloads only
                                    videos uploaded on the same day two weeks ago.

@pukkandan pukkandan self-assigned this Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs/meta/cleanup related to docs, code cleanup, templates, devscripts etc
Projects
None yet
Development

No branches or pull requests

2 participants