Fix Hidive - Subtitles and Age-restriction.

[chexxor]

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Currently the Hidive extractor is broken:

• It doesn't extract subtitles.
• It doesn't select a Hidive profile, if the user has multiple profiles defined. This applies age-restriction to the content.

After login, Hidive redirects your browser to a profile-selection page. On that page, you need to click the button/icon you want to use, which sends a JSON request to the server which sets the profile id as a cookie.

Also, the subtitle information is no longer available (from what I've seen) in a "data-captions" element on the page, but they _are_available in the "rendition" data structure that Hidive gives us.

Fixes:

• RatingRestricted HiDive #4279
• HiDive Does Not Detect or Download English Subtitle File For Japanese Audio (and other issues) #408

Before submitting a pull request make sure you have:

• At least skimmed through contributing guidelines including yt-dlp coding conventions
• Searched the bugtracker for similar pull requests
• Checked the code with flake8 and ran relevant tests

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

• I am the original author of this code and I am willing to release it under Unlicense
• I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

• Fix or improvement to an extractor (Make sure to add/update tests)
• New extractor (Piracy websites will not be accepted)
• Core bug fix/improvement
• New feature (It is strongly recommended to open an issue first)

[pukkandan]

pls explain

[chexxor]

Thanks for the encouragement to look into that!
I improved the comments in the new commit I made.

[pukkandan]

I was asking to explain it to me - coz I don't understand this code/comment. You shouldn't use long name as language code. subtitles have a separate name field

[chexxor]

With it as-is, here's what --list-subs shows:

Language     Formats
english-caps vtt
english-subs vtt

I have removed that comment in the latest version of this file -- it didn't make sense to me, either. Instead, I listed out example values in that data structure.

Do you still want me to make any changes here? This comment is on an outdated version.

[chexxor]

@pukkandan Thank you for your code review! I'm not familiar with Python, so I apologize for the dumb mistakes I made. I'll get around to fixing them sometime soon.

[chexxor]

@pukkandan Your suggestions were excellent -- thanks for the code review! I learned a lot about Python while investigating and making those improvements.

[chexxor]

Thanks for your suggested changes! I think you're much more experienced with regex than I am -- I'll review your changes, apply it and test it to ensure it still works as expected.

[chexxor]

After I made the changes you suggested, I saw that GitHub has a button to commit your changes directly to my branch -- I didn't do that, so I'm sorry if that bothered you. I'm also not sure whether you prefer I click the "Resolve" button on the items you raised, or whether you do that.

I did test these changes, and it seems to still work as expected!

[pukkandan]

After I made the changes you suggested, I saw that GitHub has a button to commit your changes directly to my branch -- I didn't do that, so I'm sorry if that bothered you.

Either is fine as long as the changes get made 👍

I'm also not sure whether you prefer I click the "Resolve" button on the items you raised, or whether you do that.

I'll resolve them

[pukkandan]

Pls reply to #5828 (comment)

Everything else looks good