[extractor/tencent]: Add more formats and info #5950

Hill-98 · 2023-01-04T17:31:48Z

Description of your pull request and other information

Use HEVC codec
Supports 4K and HDR
More information

Template

Before submitting a pull request make sure you have:

At least skimmed through contributing guidelines including yt-dlp coding conventions
Searched the bugtracker for similar pull requests
Checked the code with flake8 and ran relevant tests

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

I am the original author of this code and I am willing to release it under Unlicense
I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Fix or improvement to an extractor (Make sure to add/update tests)
New extractor (Piracy websites will not be accepted)
Core bug fix/improvement
New feature (It is strongly recommended to open an issue first)

pukkandan · 2023-01-04T18:01:24Z

Can you give an example with DRM?

Hill-98 · 2023-01-04T18:04:35Z

4K and HDR videos are available on the Tencent Video website (v.qq.com) in China, but they will only be enabled if the browser supports HEVC decoding (which is supported by the latest Chrome).

Here's an example: https://v.qq.com/x/cover/lqoxvyv6a23jo9o/b00440jumct.html

yt_dlp/extractor/tencent.py

pukkandan · 2023-01-04T23:21:10Z

There was a typo in my comment 🤦. I meant to ask for an example with DRM, sorry

* Use HEVC codec * Supports 4K and HDR * More information

Hill-98 · 2023-01-05T10:05:45Z

@pukkandan DRM example:https://v.qq.com/x/cover/v2098lbuihuqs11.html

Grub4K · 2023-01-05T10:08:12Z

Please avoid force pushing if possible. The merge will be squashed, so take as many commits as you need.

Hill-98 · 2023-01-05T10:08:51Z

Ok, I get it.

elyse0 · 2023-01-05T19:42:56Z

yt_dlp/extractor/tencent.py

+    def _extract_all_video_formats_and_subtitles(self, url, video_id, series_id):
+        first_api_response = self._get_video_api_response(url, video_id, series_id, 'vtt', 'hls', 'hd')
+        self._check_api_response(first_api_response)
+        api_responses = [first_api_response]
+        quality = self._extract_all_video_quality(first_api_response)
+        for q in quality:
+            if q != 'sd' and q != 'hd':
+                api_response = self._get_video_api_response(
+                    url, video_id, series_id, 'vtt', 'hls', q)
+                self._check_api_response(api_response)
+                api_responses.append(api_response)


The current yt-dlp is able to get 480p direct links, now those are missing

yt-dlp 2022.10.04

[debug] Command-line config: ['https://wetv.vip/play/7csb8h9c79p8idi/a0041yw44yk', '-F', '--verbose'] [debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8, error utf-8, screen utf-8 [debug] yt-dlp version 2022.10.04 [4e0511f27] (debian*) API [debug] Python 3.10.7 (CPython 64bit) - Linux-5.19.0-26-generic-x86_64-with-glibc2.36 (glibc 2.36) [debug] Checking exe version: ffmpeg -bsfs [debug] Checking exe version: ffprobe -bsfs [debug] exe versions: ffmpeg N-108931-g4dda3b1653-20221104 (setts), ffprobe N-108931-g4dda3b1653-20221104, phantomjs 140337668638656, rtmpdump 2.4 [debug] Optional libraries: Cryptodome-3.11.0, brotli-1.0.9, certifi-2022.06.15, mutagen-1.45.1, pyxattr-0.7.2, secretstorage-3.3.3, sqlite3-2.6.0, websockets-10.2 [debug] Proxy map: {} [debug] Loaded 1690 extractors [debug] [wetv:episode] Extracting URL: https://wetv.vip/play/7csb8h9c79p8idi/a0041yw44yk [wetv:episode] a0041yw44yk: Downloading webpage [wetv:episode] a0041yw44yk: Downloading webpage [wetv:episode] a0041yw44yk: Downloading webpage [wetv:episode] a0041yw44yk: Downloading m3u8 information [wetv:episode] a0041yw44yk: Downloading m3u8 information [wetv:episode] a0041yw44yk: Downloading webpage [wetv:episode] a0041yw44yk: Downloading m3u8 information [wetv:episode] a0041yw44yk: Downloading m3u8 information [debug] Formats sorted by: hasvid, ie_pref, lang, quality, res, fps, hdr:12(7), vcodec:vp9.2(10), channels, acodec, filesize, fs_approx, tbr, vbr, abr, asr, proto, vext, aext, hasaud, source, id [info] Available formats for a0041yw44yk: ID EXT RESOLUTION │ PROTO │ VCODEC ACODEC ─────────────────────────────────────────── 0 mp4 864x362 │ https │ unknown unknown 1 mp4 864x362 │ https │ unknown unknown 2 mp4 864x362 │ https │ unknown unknown 3 mp4 864x362 │ https │ unknown unknown 4 mp4 1280x536 │ m3u8 │ unknown unknown 5 mp4 1280x536 │ m3u8 │ unknown unknown 6 mp4 1280x536 │ m3u8 │ unknown unknown 7 mp4 1280x536 │ m3u8 │ unknown unknown

Your branch

[debug] Command-line config: ['https://wetv.vip/play/7csb8h9c79p8idi/a0041yw44yk', '--verbose', '-F'] [debug] User config: [] [debug] System config: [] [debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8, error utf-8, screen utf-8 [debug] yt-dlp version 2023.01.02 [d83b0ad80] (source) [debug] Lazy loading extractors is disabled [debug] Git HEAD: 62bd9c276 [debug] Python 3.10.7 (CPython x86_64 64bit) - Linux-5.19.0-26-generic-x86_64-with-glibc2.36 (OpenSSL 3.0.5 5 Jul 2022, glibc 2.36) [debug] exe versions: ffmpeg N-108931-g4dda3b1653-20221104 (setts), ffprobe N-108931-g4dda3b1653-20221104, phantomjs broken, rtmpdump 2.4 [debug] Optional libraries: Cryptodome-3.15.0, certifi-2022.09.24, mutagen-1.46.0, sqlite3-2.6.0, websockets-10.4 [debug] Proxy map: {} [debug] Loaded 1756 extractors [wetv:episode] Extracting URL: https://wetv.vip/play/7csb8h9c79p8idi/a0041yw44yk [wetv:episode] a0041yw44yk: Downloading webpage [wetv:episode] a0041yw44yk: Downloading webpage [wetv:episode] a0041yw44yk: Downloading webpage [wetv:episode] a0041yw44yk: Downloading webpage [wetv:episode] a0041yw44yk: Downloading webpage [wetv:episode] a0041yw44yk: Downloading m3u8 information [wetv:episode] a0041yw44yk: Downloading m3u8 information [wetv:episode] a0041yw44yk: Downloading m3u8 information [wetv:episode] a0041yw44yk: Downloading m3u8 information [wetv:episode] a0041yw44yk: Downloading m3u8 information [wetv:episode] a0041yw44yk: Downloading m3u8 information [wetv:episode] a0041yw44yk: Downloading m3u8 information [wetv:episode] a0041yw44yk: Downloading m3u8 information [debug] Formats sorted by: hasvid, ie_pref, lang, quality, res, fps, hdr:12(7), vcodec:vp9.2(10), channels, acodec, filesize, fs_approx, tbr, vbr, abr, asr, proto, vext, aext, hasaud, source, id [info] Available formats for a0041yw44yk: ID EXT RESOLUTION FPS │ PROTO │ VCODEC ACODEC MORE INFO ────────────────────────────────────────────────────────── 0 mp4 256x108 0 │ m3u8 │ unknown unknown ld (144P) 1 mp4 256x108 0 │ m3u8 │ unknown unknown ld (144P) 2 mp4 864x362 0 │ m3u8 │ unknown unknown hd (480P) 3 mp4 864x362 0 │ m3u8 │ unknown unknown hd (480P) 4 mp4 1280x536 0 │ m3u8 │ unknown unknown shd (720P) 5 mp4 1280x536 0 │ m3u8 │ unknown unknown shd (720P) 6 mp4 1280x536 0 │ m3u8 │ unknown unknown shd (720P) 7 mp4 1280x536 0 │ m3u8 │ unknown unknown shd (720P)

This is expected because the list of qualities returned by the API will not include 4K and HDR if the API is requested without the hls format.

Maybe we should call both API? Removing existing formats is a regression and should only be done when there is no other choice

@pukkandan, the extraction speed for those outside of China is pretty bad, especially if you are using proxy to unblock content. In my daily use, with proxy, it takes 15–30 seconds to extract all AVC formats, in which case, extracting AVC and HEVC would double, right?

My opinion is to add all formats by default, and have an extract-arg to limit it. I think the current video_codec is too limited. We still have to download multiple m3u8s for a single codec. Something like formats=hevc-hd,avc-fhd would be better imo

No, we'd better not fetch both avc and hevc, even in China, it's a burden, and too many calls to the API might get blocked.

Alright. What do you think of the suggested change to extractor-arg?

Do you mean change video_codec to formats? Looks good, but doesn't add much value, and I think very few people need to download videos with both encoders.

I'm confused. Calling the API is expensive, but an option to reduce number of m3u8 downloads doesn't add value?

Sorry, my fault, I misunderstood. It does have value, and I'll consider it when I have time.

yt_dlp/extractor/tencent.py

Hill-98 · 2023-01-06T08:07:06Z

By the way, I actually want to disassemble the implementation of vqq and WeTV. Although they are very similar at the API level, they are still different in terms of content.

This can also reduce maintenance costs, and Chinese users can only focus on vqq.

Hill-98 · 2023-01-06T11:41:10Z

The Japanese proxy I used was tested on WeTV, so there is no guarantee that it will work in all countries.

yt_dlp/extractor/tencent.py

elyse0

Are all tests up to date? I get an error on WeTvEpisode extractor

python3 test/test_download.py TestDownload.test_WeTvEpisode
[debug] Loaded 1756 extractors
[wetv:episode] Extracting URL: https://wetv.vip/en/play/air11ooo2rdsdi3-Cute-Programmer/v0040pr89t9-EP1-Cute-Programmer
[wetv:episode] v0040pr89t9: Downloading webpage
[wetv:episode] v0040pr89t9: Downloading webpage
[debug] Formats sorted by: hasvid, ie_pref, lang, quality, res, fps, hdr:12(7), vcodec:vp9.2(10), channels, acodec, filesize, fs_approx, tbr, vbr, abr, asr, proto, vext, aext, hasaud, source, id
[info] v0040pr89t9: Downloading 1 format(s): 3
[info] Writing video metadata as JSON to: test_WeTvEpisode_v0040pr89t9.info.json
[debug] Invoking http downloader on "https://apd-vlive.apdcdn.tc.qq.com/wetvvlive.qqvideo.tc.qq.com/uwMRJ_z-r5pAYaQXGdGnFWde8_uKQ6p7LL8hY22lcu2s4A/svp_50125/gzc_1000117_0b53jyaaaaaatiaonjkd5nq42twdabbaabka.f2.mp4?vkey=B96FD54DD4DD4C114A919FAE44447567AE2F3FA0993D6D7106DF924AB8BD05E2077D207866808D7AD3CE3023B06A792AD4F0618130D78D81C95AD11EDA98297F826C9AC984520A296B54F34EA281BD3C28BDBDF0668F22F9D215652D3C545D1472DE3767FDB5868AE68B4EBEF89356E897B0CCD8DBD78F6B25798A649E2EF7EB"
[download] Destination: test_WeTvEpisode_v0040pr89t9.mp4
[download] 100% of   10.00KiB in 00:00:00 at 55.39KiB/s
F
======================================================================
FAIL: test_WeTvEpisode (__main__.TestDownload):
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/amish/Documents/Programming/yt-dlp/test/test_download.py", line 215, in test_template
    expect_info_dict(self, tc_res_dict, tc.get('info_dict', {}))
  File "/home/amish/Documents/Programming/yt-dlp/test/helper.py", line 233, in expect_info_dict
    expect_dict(self, got_dict, expected_dict)
  File "/home/amish/Documents/Programming/yt-dlp/test/helper.py", line 186, in expect_dict
    expect_value(self, got, expected, info_field)
  File "/home/amish/Documents/Programming/yt-dlp/test/helper.py", line 178, in expect_value
    self.assertEqual(
AssertionError: 'shd' != 'hd'
- shd
? -
+ hd
 : Invalid value for field format_id , expected 'shd', got 'hd'

----------------------------------------------------------------------
Ran 1 test in 1.710s

FAILED (failures=1)

yt_dlp/extractor/tencent.py

Hill-98 · 2023-01-08T08:21:44Z

@elyse0 Yes, All Test is update.

My test results:

python test/test_download.py TestDownload.test_WeTvEpisode_all

[debug] Loaded 1756 extractors 
[wetv:episode] Extracting URL: https://wetv.vip/en/play/air11ooo2rdsdi3-Cute-Programmer/v0040pr89t9-EP1-Cute-Programmer
[wetv:episode] v0040pr89t9: Downloading webpage
[wetv:episode] v0040pr89t9: Downloading webpage 
[wetv:episode] v0040pr89t9: Downloading webpage 
[wetv:episode] v0040pr89t9: Downloading webpage 
[wetv:episode] v0040pr89t9: Downloading m3u8 information 
[wetv:episode] v0040pr89t9: Downloading m3u8 information 
[wetv:episode] v0040pr89t9: Downloading m3u8 information 
[wetv:episode] v0040pr89t9: Downloading m3u8 information 
[wetv:episode] v0040pr89t9: Downloading m3u8 information 
[wetv:episode] v0040pr89t9: Downloading m3u8 information 
[debug] Formats sorted by: hasvid, ie_pref, lang, quality, res, fps, hdr:12(7), vcodec:vp9.2(10), channels, acodec, filesize, fs_approx, tbr, vbr, abr, asr, proto, vext, aext, hasaud, source, id
[info] v0040pr89t9: Downloading 1 format(s): 5
[info] Writing video metadata as JSON to: test_WeTvEpisode_v0040pr89t9.info.json
[debug] Invoking hlsnative downloader on "https://apd-vlive.apdcdn.tc.qq.com/wetvdefaultts.tc.qq.com/uwMRJfz-r5jAYaQXGdGnDNa47wxmj-p1Os_O5t_4amE/svp_50125/IGwe-65sY493w0pOgBQaA98E2CsaRPvtPmqSSlQu2NKGTZppkP4DdIV1cd2rkNSgBebyRzwu5BFn0141BG9s7Ro04iheEtsArwBeJr_tjWHR2FwUVyVrXLAgduuzp5xZk9VrU47S_Srbf-oqyvcWMylL9hpTzmb5ezA9eU6LdYU/gzc_1000117_0b53jyaaaaaatiaonjkd5nq42twdabbaabka.f323013001.ts.m3u8?ver=4"
[hlsnative] Downloading m3u8 manifest
[hlsnative] Total fragments: 245 
[download] Destination: test_WeTvEpisode_v0040pr89t9.mp4
[debug] File locking is not supported. Proceeding without locking[debug] File locking is not supported. Proceed[download]   0.4% of ~ 282.71MiB at  577.17KiB/s ETA 08:19 (frag 1/245)[debug] File locking is not supported. P[download] 100% of    1.15MiB in 00:00:02 at 576.60KiB/s
[debug] Loaded 1756 extractors 
[wetv:episode] Extracting URL: https://wetv.vip/en/play/u37kgfnfzs73kiu/p0039b9nvik
[wetv:episode] p0039b9nvik: Downloading webpage
[wetv:episode] p0039b9nvik: Downloading webpage 
[wetv:episode] p0039b9nvik: Downloading webpage 
[wetv:episode] p0039b9nvik: Downloading webpage 
[wetv:episode] p0039b9nvik: Downloading m3u8 information 
[wetv:episode] p0039b9nvik: Downloading m3u8 information 
[wetv:episode] p0039b9nvik: Downloading m3u8 information 
[wetv:episode] p0039b9nvik: Downloading m3u8 information 
[wetv:episode] p0039b9nvik: Downloading m3u8 information 
[wetv:episode] p0039b9nvik: Downloading m3u8 information 
[debug] Formats sorted by: hasvid, ie_pref, lang, quality, res, fps, hdr:12(7), vcodec:vp9.2(10), channels, acodec, filesize, fs_approx, tbr, vbr, abr, asr, proto, vext, aext, hasaud, source, id
[info] p0039b9nvik: Downloading 1 format(s): 5
[info] Writing video metadata as JSON to: test_WeTvEpisode_1_p0039b9nvik.info.json
[debug] Invoking hlsnative downloader on "https://apd-vlive.apdcdn.tc.qq.com/wetvdefaultts.tc.qq.com/uwMRJfz-r5jAYaQXGdGnDNa47wxmj-p1Os_O5t_4amE/svp_50125/W4037pcB4mEFUr7lm0DR75KHGYtfFjQR3Xp5l7mdNUXc7mukPiPrbgl4zqhHFHzgD3vyK7fBSZ9bH5Qti9LYEnVv3ItOfU2VkuyITbRlL2afEwwxL0fMYP8j6Jhw8cbAH9BulOGowzdfIzbhO3_lxszygKzrqHnzScS7XXJReZo/gzc_1000117_0b53lyaagaaaryakirs7mbq42xwdanjaabsa.f323013001.ts.m3u8?ver=4"
[hlsnative] Downloading m3u8 manifest
[hlsnative] Total fragments: 242 
[download] Destination: test_WeTvEpisode_1_p0039b9nvik.mp4
[debug] File locking is not supported. Proceeding without locking[debug] File locking is not supported. Proceed[download]   0.4% of ~  58.49MiB at  254.59KiB/s ETA 03:54 (frag 1/242)[debug] File locking is not supported. P[download] 100% of  247.48KiB in 00:00:00 at 253.80KiB/s
[debug] Loaded 1756 extractors 
[wetv:episode] Extracting URL: https://wetv.vip/en/play/lcxgwod5hapghvw-WeTV-PICK-A-BOO/i0042y00lxp-Zhao-Lusi-Describes-The-First-Experiences-She-Had-In-Who-Rules-The-World-%7C-WeTV-PICK-A-BOO
[wetv:episode] i0042y00lxp: Downloading webpage
[wetv:episode] i0042y00lxp: Downloading webpage 
[wetv:episode] i0042y00lxp: Downloading webpage 
[wetv:episode] i0042y00lxp: Downloading webpage 
[wetv:episode] i0042y00lxp: Downloading m3u8 information 
[wetv:episode] i0042y00lxp: Downloading m3u8 information 
[wetv:episode] i0042y00lxp: Downloading m3u8 information 
[wetv:episode] i0042y00lxp: Downloading m3u8 information 
[wetv:episode] i0042y00lxp: Downloading m3u8 information 
[wetv:episode] i0042y00lxp: Downloading m3u8 information 
[debug] Formats sorted by: hasvid, ie_pref, lang, quality, res, fps, hdr:12(7), vcodec:vp9.2(10), channels, acodec, filesize, fs_approx, tbr, vbr, abr, asr, proto, vext, aext, hasaud, source, id
[info] i0042y00lxp: Downloading 1 format(s): 5
[info] Writing video metadata as JSON to: test_WeTvEpisode_2_i0042y00lxp.info.json
[debug] Invoking hlsnative downloader on "https://apd-vlive.apdcdn.tc.qq.com/wetvdefaultts.tc.qq.com/uwMRJfz-r5jAYaQXGdGnDNa47wxmj-p1Os_O5t_4amE/svp_50125/PEee-lUZcPW68D9XQ_CpOcKapsFCZI5Pw0pmmJq-ocIje31mkJx_caPJKhrQ1S1HdH2Q9TrJVxrS3OkBMrRhDY-5qhTQ6HspqrBcC8_x1UltP9hk00yCkz3wVeBwPd5YApuNzw8z2wvuAer0uvC-YPpGHRpaeWnxvDnJrxUWVFQ/gzc_1000117_0b53siaaaaaa2uak5g344vrm3ewdacpaabka.f323013.ts.m3u8?ver=4"
[hlsnative] Downloading m3u8 manifest
[hlsnative] Total fragments: 38 
[download] Destination: test_WeTvEpisode_2_i0042y00lxp.mp4
[debug] File locking is not supported. Proceeding without locking[debug] File locking is not supported. Proceed[download]   2.6% of ~  19.55MiB at  493.45KiB/s ETA 00:39 (frag 1/38)[debug] File locking is not supported. Pr[download] 100% of  526.73KiB in 00:00:01 at 492.53KiB/s
.
----------------------------------------------------------------------
Ran 1 test in 28.535s

OK

yt_dlp/extractor/tencent.py

D0LLYNH0 · 2023-01-14T07:09:31Z

Excellent extractor improvement, really appreciated.
The HEVC versions really are superior, the H264 codec also doesn't have 4K quality available, but still, wouldn't it be a good idea to keep the H264 option available via --extractor-args? <= Full HD (H264) can still be useful.

Hill-98 · 2023-01-14T07:12:15Z

@D0LLYNH0 That's a good idea, I'll look at how to add parameters to extractor later.

This reverts commit 8c5821e.

pukkandan

I have reverted the extractor-arg for now. Once you confirm I haven't broken anything, we can merge this PR. You can make a separate PR with the arg later

yt_dlp/extractor/tencent.py

pukkandan · 2023-02-17T09:09:50Z

I have reverted the extractor-arg for now. Once you confirm I haven't broken anything, we can merge this PR. You can make a separate PR with the arg later

Still waiting for confirmation

Hill-98 · 2023-02-17T09:11:21Z

I'll test it when I have time, and wait for some time.

pukkandan · 2023-02-17T09:12:04Z

👍 Just wanted to make sure the message was seen

Hill-98 · 2023-02-17T12:03:20Z

Nothing is broken. But I made some small changes to make the format_note display the same as the web page.

But I don't know why the GitHub Action check fails.

pukkandan · 2023-02-17T12:45:16Z

But I made some small changes to make the format_note display the same as the web page.

We don't want it to be same as website. The field is used for adding additional data that doesn't fit in the other fields

Hill-98 · 2023-02-17T12:56:29Z

Okay, that's no more questions, it can be merged.

I will do PR for arg when I have time.

Authored by: Hill-98

elyse0 reviewed Jan 4, 2023

View reviewed changes

yt_dlp/extractor/tencent.py Outdated Show resolved Hide resolved

yt_dlp/extractor/tencent.py Outdated Show resolved Hide resolved

yt_dlp/extractor/tencent.py Outdated Show resolved Hide resolved

yt_dlp/extractor/tencent.py Outdated Show resolved Hide resolved

Grub4K reviewed Jan 4, 2023

View reviewed changes

yt_dlp/extractor/tencent.py Show resolved Hide resolved

Hill-98 force-pushed the enhance-tencent-extractor branch from f49f600 to 95bc926 Compare January 5, 2023 09:59

[extractor/tencent]: Add more formats and info

b72208d

* Use HEVC codec * Supports 4K and HDR * More information

Hill-98 force-pushed the enhance-tencent-extractor branch from 95bc926 to b72208d Compare January 5, 2023 10:02

Hill-98 added 2 commits January 5, 2023 19:06

Fix incorrect API query parameters

8af7c5b

Improve code readability

62bd9c2

Hill-98 force-pushed the enhance-tencent-extractor branch from e1e226d to 62bd9c2 Compare January 5, 2023 11:25

elyse0 reviewed Jan 5, 2023

View reviewed changes

Hill-98 added 2 commits January 6, 2023 19:16

Get srt subtitles

38bbd0d

Fix WeTv and Iflix test

091bbc8

Hill-98 force-pushed the enhance-tencent-extractor branch from 7c83c61 to 091bbc8 Compare January 6, 2023 11:39

elyse0 reviewed Jan 7, 2023

View reviewed changes

Improvement Code

2c1711f

elyse0 suggested changes Jan 7, 2023

View reviewed changes

yt_dlp/extractor/tencent.py Outdated Show resolved Hide resolved

Fix special case of has_drm

c318438

elyse0 reviewed Jan 8, 2023

View reviewed changes

yt_dlp/extractor/tencent.py Outdated Show resolved Hide resolved

Fix error for extra spaces

4936d73

elyse0 approved these changes Jan 9, 2023

View reviewed changes

yt_dlp/extractor/tencent.py Show resolved Hide resolved

pukkandan added the site-enhancement Feature request for some website label Jan 9, 2023

pukkandan self-requested a review January 9, 2023 15:13

Hill-98 and others added 2 commits January 15, 2023 01:35

Add extractor arg: video_codec

8c5821e

Revert "Add extractor arg: video_codec"

84298b4

This reverts commit 8c5821e.

pukkandan approved these changes Feb 12, 2023

View reviewed changes

yt_dlp/extractor/tencent.py Outdated Show resolved Hide resolved

yt_dlp/extractor/tencent.py Outdated Show resolved Hide resolved

yt_dlp/extractor/tencent.py Outdated Show resolved Hide resolved

yt_dlp/extractor/tencent.py Outdated Show resolved Hide resolved

cleanup

3b9025c

pukkandan reviewed Feb 12, 2023

View reviewed changes

Apply suggestions from code review

0a74b60

pukkandan added the needs-testing Patch needs testing label Feb 12, 2023

Hill-98 force-pushed the enhance-tencent-extractor branch from 54efafd to 630a7ed Compare February 17, 2023 11:59

Hill-98 force-pushed the enhance-tencent-extractor branch from 630a7ed to 0a74b60 Compare February 17, 2023 12:54

pukkandan merged commit 18d295c into yt-dlp:master Feb 17, 2023

aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024

[extractor/tencent] Add more formats and info (yt-dlp#5950)

c374f2e

Authored by: Hill-98

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[extractor/tencent]: Add more formats and info #5950

[extractor/tencent]: Add more formats and info #5950

Hill-98 commented Jan 4, 2023

pukkandan commented Jan 4, 2023 •

edited

Hill-98 commented Jan 4, 2023

pukkandan commented Jan 4, 2023 •

edited

Hill-98 commented Jan 5, 2023

Grub4K commented Jan 5, 2023

Hill-98 commented Jan 5, 2023

elyse0 Jan 5, 2023

Hill-98 Jan 6, 2023

pukkandan Feb 12, 2023 •

edited

D0LLYNH0 Feb 12, 2023

pukkandan Feb 12, 2023

Hill-98 Feb 12, 2023

pukkandan Feb 12, 2023

Hill-98 Feb 12, 2023

pukkandan Feb 12, 2023

Hill-98 Feb 12, 2023

Hill-98 commented Jan 6, 2023 •

edited

Hill-98 commented Jan 6, 2023

elyse0 left a comment

Hill-98 commented Jan 8, 2023

D0LLYNH0 commented Jan 14, 2023 •

edited

Hill-98 commented Jan 14, 2023

pukkandan left a comment

pukkandan commented Feb 17, 2023

Hill-98 commented Feb 17, 2023

pukkandan commented Feb 17, 2023

Hill-98 commented Feb 17, 2023

pukkandan commented Feb 17, 2023

Hill-98 commented Feb 17, 2023

[extractor/tencent]: Add more formats and info #5950

[extractor/tencent]: Add more formats and info #5950

Conversation

Hill-98 commented Jan 4, 2023

Description of your pull request and other information

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

What is the purpose of your pull request?

pukkandan commented Jan 4, 2023 • edited

Hill-98 commented Jan 4, 2023

pukkandan commented Jan 4, 2023 • edited

Hill-98 commented Jan 5, 2023

Grub4K commented Jan 5, 2023

Hill-98 commented Jan 5, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pukkandan Feb 12, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Hill-98 commented Jan 6, 2023 • edited

Hill-98 commented Jan 6, 2023

elyse0 left a comment

Choose a reason for hiding this comment

Hill-98 commented Jan 8, 2023

D0LLYNH0 commented Jan 14, 2023 • edited

Hill-98 commented Jan 14, 2023

pukkandan left a comment

Choose a reason for hiding this comment

pukkandan commented Feb 17, 2023

Hill-98 commented Feb 17, 2023

pukkandan commented Feb 17, 2023

Hill-98 commented Feb 17, 2023

pukkandan commented Feb 17, 2023

Hill-98 commented Feb 17, 2023

pukkandan commented Jan 4, 2023 •

edited

pukkandan commented Jan 4, 2023 •

edited

pukkandan Feb 12, 2023 •

edited

Hill-98 commented Jan 6, 2023 •

edited

D0LLYNH0 commented Jan 14, 2023 •

edited