[extractor/Dumpert] Fix videos downloading as m3u8 files and added new-style valid URLs #6091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Imported youtube-dl upstream PR#30985 and removed the deprecated parts
pukkandan
requested changes
Feb 12, 2023
yt_dlp/extractor/dumpert.py
Outdated
| int_or_none, | ||
| qualities, | ||
| ) | ||
|
|
||
|
|
||
| class DumpertIE(InfoExtractor): | ||
| _VALID_URL = r'(?P<protocol>https?)://(?:(?:www|legacy)\.)?dumpert\.nl/(?:mediabase|embed|item)/(?P<id>[0-9]+[/_][0-9a-zA-Z]+)' | ||
| _VALID_URL = r'(?P<protocol>https?)://(?:(?:www|legacy)\.)?dumpert\.nl(?:/(?:mediabase|embed|item)/|(?:/toppers|/latest|/?)\?selectedId=)(?P<id>[0-9]+[/_][0-9a-zA-Z]+)' |
There was a problem hiding this comment.
This's gotten complicated. Can you split it into multiple lines?
pukkandan
added
site-bug
pukkandan
force-pushed
the
master
branch
2 times, most recently
from
ee280c7
to
7aeda6c
Compare
aalsuwaidi
pushed a commit
to aalsuwaidi/yt-dlp
that referenced
this pull request
Apr 21, 2024
Authored by: DataGhost, pukkandan Closes yt-dlp#5032
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imported youtube-dl upstream PR#30985 and removed the deprecated parts
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
Dumpert has changed playout to HLS a while ago (months or even over a year) which causes all videos since that change to download as .m3u8 files actually containing mp4 data. Older videos are unaffected, that's why the test never failed. Additionally, the site has received a new layout with some new possible URLs a while ago, those should now work as well.
The manifests seem to be single-quality and basically just contain a single mp4 each, last time I checked. It's downloading correctly this way for me anyway.
This PR was previously made on youtube-dl#30985 and I think it was good to go but the project went mostly inactive and it hasn't been merged to date. So I merged it into a yt-dlp repo, making sure the previously cleaned-up deprecated stuff stayed cleaned-up.
Fixes #5032
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?