-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[extractor/vocaroo] Add Vocaroo extractor #6117
Conversation
The current extractor doesn't seem to support embeds. Provide example |
I added your suggestions, but I want to mention that IDs don't have underscores, and the filename is in the format |
There is an |
You can can make a Actually, sending the request might be a good thing. The extractor currently just guesses that an audio file exists with the given ID, whereas making at least one request will reveal whether the ID is valid (or perhaps that the extractor's guess is no longer valid). In my test I found that a |
I made the logic for the media subdomain match the logic of the site function (e) {
if (e.length) {
if (11 == e.length)
return ControlConfig.mediaMp3FileUrl;
if (12 == e.length && '1' == e[0])
return ControlConfig.mediaMp3FileUrl1;
if (10 == e.length)
return ControlConfig.mediaMp3FileUrl1
}
return ControlConfig.mediaMp3FileUrl
}
Can you give an example? I assumed they were mirrors. |
Co-authored-by: pukkandan <pukkandan.ytdlp@gmail.com>
Hey! Looks like some more of my code made it into yt-dlp. I have no issue with my code being used without permission—it is public domain after all—but being mentioned would have been nice; would've been happy to help and would have closed the PR in youtube-dl. That's all; sorry for waking a sleeping thread. |
@SuperSonicHub1 You are credited in commit message and changelog |
Thanks, @pukkandan! |
Authored by: qbnu, SuperSonicHub1 Closes yt-dlp#6152
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
(Description from ytdl-org/youtube-dl#29369)
Adds support for Vocaroo, "the premier voice recording service." The site lacks any sort of metadata for its uploads and all come down as MP3s, so much of this extractor is hardcoded, making it quite fast. While Vocaroo does allow you to easily download individual files from their site, youtube-dl support will allow users to extract Vocaroo embeds with the generic extractor and download many Vocaroo files at once.
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?