[extractor/vk] playlist fix for new API requirements

[the-marenga]

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

As reported here, VK playlist downloads stopped working. The reason is, that their API has been changed yet again and now requires "playlist_ID" instead of just "ID" as a request parameter. With this fix everything works again

Fixes #4930 (comment)

PLEASE FOLLOW THE GUIDE BELOW

Before submitting a pull request make sure you have:

• At least skimmed through contributing guidelines including yt-dlp coding conventions
• Searched the bugtracker for similar pull requests
• Checked the code with flake8 and ran relevant tests

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

• I am the original author of this code and I am willing to release it under Unlicense
• I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

• Fix or improvement to an extractor (Make sure to add/update tests)
• New extractor (Piracy websites will not be accepted)
• Core bug fix/improvement
• New feature (It is strongly recommended to open an issue first)

[pukkandan]

Have you tested that the other code branches does not need this change?

[the-marenga]

Yes, the other branches are for URLs, that either provide their own valid section id, or download an entire channel 'all'. Both of these are still what VK uses in their requests unchanged.

I did however just notice, that I forgot to update the playlist test, so I fixed that.

When doing so I also noticed, that most of the single video (VKIE) tests either fail for various reasons, or get skipped because the video has been removed. I think they were already failing months ago, but I am not sure. If you want me to, I can just update all of the tests in the extractor (either in this PR, or another one?) to make sure nothing there has been broken by this or an older API change

[pukkandan]

If you want me to, I can just update all of the tests in the extractor (either in this PR, or another one?) to make sure nothing there has been broken by this or an older API change

Sure, you can do it in same PR

[the-marenga]

I updated all the tests and it seems like they did in fact change their site somewhere else.

They changed their wallposts audio data to JSON and removed the url encryption, which crashed the previously already non-functioning audio extraction completely. I fixed that, but downloading still returned an error from the 'FFmpegFixupM3u8PP', because the audio stream is mp3 and not the expected aac. I changed the container to mov to hide the error for now. The files would however actually need a simple fixup, as they are currently only playable with a handful of media players. A real fix for this would be to have a url check in the fixup, to ommit the incompatible stuff:

if all(self._needs_fixup(info)):
    if 'vkuseraudio.net' in info['url']:
        self._fixup('Fixing MPEG-TS in MP4 container', info['filepath'], [
            *self.stream_copy_opts(), '-f', 'mp4'])
    else:
        self._fixup('Fixing MPEG-TS in MP4 container', info['filepath'], [
            *self.stream_copy_opts(), '-f', 'mp4', '-bsf:a', 'aac_adtstoasc'])

but that seems like an inelegant way to do this and I am not familiar enough with the codebase to come up with a better alternative. For now you would either have to play the files in something like mpv, or use -x to extract the actual audio manually.

VK also lifted a lot of restrictions to being registered, so a lot of tests for edge cases are no longer required and some don't need to be skipped anymore.

All tests succeed now

[pukkandan]

The files would however actually need a simple fixup, as they are currently only playable with a handful of media players.

If it's mp3, what kind of fixup does it need?

[the-marenga]

Great, the files are playable and have no corruptions.
I just changed the author extraction class, because vk changed it within the last few days and updated the tests.
Only thing left would be merging the audio & video entries again when returning, but I couldn't figure out how to append the audio entries to the playlist_from_matches without basically reverting that change from your cleanup back to using 'playlist_result'

[pukkandan]

Only thing left would be merging the audio & video entries again when returning, but I couldn't figure out how to append the audio entries to the playlist_from_matches without basically reverting that change from your cleanup back to using 'playlist_result'

My bad. Reverted

[the-marenga]

When doing final testing, I noticed, that irrelevant reaction clips in the comments will also be picked up. That seemed like a bug to me, so I fixed that by only searching for videos in the actual post body. Otherwise everything should be good