-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix for radiko.jp #6159
Merged
Merged
Hotfix for radiko.jp #6159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lesmiscore
reviewed
Feb 5, 2023
Co-authored-by: Lesmiscore <nao20010128@gmail.com>
pukkandan
requested changes
Feb 5, 2023
yt_dlp/extractor/radiko.py
Outdated
@@ -92,9 +109,11 @@ def _extract_formats(self, video_id, station, is_onair, ft, cursor, auth_token, | |||
formats = [] | |||
found = set() | |||
for url_tag in m3u8_urls: | |||
pcu = url_tag.find('playlist_create_url') | |||
pcu = url_tag.find('playlist_create_url').text | |||
if is_onair and not pcu.startswith(self._HOSTS_FOR_LIVE) or (not is_onair and (pcu.startswith(self._HOSTS_FOR_TIME_FREE_FFMPEG_UNSUPPORTED) or pcu.startswith(self._HOSTS_FOR_LIVE)))): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this can be simplified to:
Suggested change
if is_onair and not pcu.startswith(self._HOSTS_FOR_LIVE) or (not is_onair and (pcu.startswith(self._HOSTS_FOR_TIME_FREE_FFMPEG_UNSUPPORTED) or pcu.startswith(self._HOSTS_FOR_LIVE)))): | |
if (on_air ^ pcu.startswith(self._HOSTS_FOR_LIVE)) or ( | |
not is_onair and pcu.startswith(self._HOSTS_FOR_TIME_FREE_FFMPEG_UNSUPPORTED)): |
pukkandan
added
site-bug
Issue with a specific website
pending-fixes
PR has had changes requested
labels
Feb 8, 2023
aalsuwaidi
pushed a commit
to aalsuwaidi/yt-dlp
that referenced
this pull request
Apr 21, 2024
Authored by: road-master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your pull request and other information
Summary of issue:
Can't download radiko.jp Time Free.
See also: #6090
Cause
The update of radiko.jp.
Some of supplied hosts are not supported by FFmpeg.
Note that the version of FFmpeg is not related with this issue.
Summary of update
Filter supplied hosts before check details of them.
is_onair
and implement method likeis_unsupported_host()
into class:RadikoIE
andRadikoRadioIE
instead and move condition into its method.Confirmed tests
Investigation result
radiko.jp
is the firstest host to downloadradiko.jp
c-radiko.smartstream.ne.jp
, FFmpeg forcibly connects not Time Free but Live.Template
Before submitting a pull request make sure you have:
(Maybe, automated test for radiko.jp doesn't exist.)
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?