feat: add extractor for ebay video listings #6170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pukkandan
requested changes
Feb 6, 2023
pukkandan
requested changes
Feb 8, 2023
pukkandan
added
site-request
I wasn't able to find any where there was more than one video, so I suppose it's safe to assume that they all only have a single video. I made the change to use the html title instead 👍 |
pukkandan
approved these changes
Feb 9, 2023
yt_dlp/extractor/ebay.py
Outdated
|
|
||
| return { | ||
| 'id': video_id, | ||
| 'title': self._html_extract_title(webpage), |
There was a problem hiding this comment.
Suggested change
| 'title': self._html_extract_title(webpage), | |
| 'title': remove_end(self._html_extract_title(webpage), ' | eBay'), |
yt_dlp/extractor/ebay.py
Outdated
| elif key == 'DASH': | ||
| formats.extend(self._extract_mpd_formats(url, video_id, fatal=False)) | ||
| else: | ||
| self.report_warning('unsupported format found: %s' % key, video_id) |
There was a problem hiding this comment.
Suggested change
| self.report_warning('unsupported format found: %s' % key, video_id) | |
| self.report_warning(f'Unsupported format {key}', video_id) |
aalsuwaidi
pushed a commit
to aalsuwaidi/yt-dlp
that referenced
this pull request
Apr 21, 2024
Closes yt-dlp#6134 Authored by: JChris246
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your pull request and other information
This PR seeks to add an extractor for ebay video listings as described in issue #6134
Fixes #6134
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?