Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extractor/twitter] Fix --no-playlist and add media view_count when using GraphQL #6211

Merged
merged 5 commits into from
Feb 12, 2023

Conversation

Grub4K
Copy link
Member

@Grub4K Grub4K commented Feb 11, 2023

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Fixes the behavior of --no-playlist when image media is present. It also now adds the old archive id to the post and adds #2 to the title like with playlist items.

It also adds extraction of view_count when using GraphQL (per media item, not per tweet). This makes all native video tests fail when using GraphQL since view_count is not defined in the test. A specific test for using force_graphql extractor arg has been added instead.

Fixes #6210
Addresses one part of #5807

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

yt_dlp/extractor/twitter.py Outdated Show resolved Hide resolved
yt_dlp/extractor/twitter.py Outdated Show resolved Hide resolved
Grub4K and others added 2 commits February 11, 2023 19:04
Co-authored-by: pukkandan <pukkandan.ytdlp@gmail.com>
@Grub4K Grub4K merged commit b6795fd into yt-dlp:master Feb 12, 2023
@Grub4K Grub4K deleted the fix/twitter-various branch April 30, 2023 15:01
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[twitter] --no-playlist param leads to failed download for posts with image+video
2 participants