Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[recurbate.com] Add recurbate extractor #6297

Merged
merged 8 commits into from May 31, 2023
Merged

Conversation

mrscrapy
Copy link
Contributor

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

This is a new extractor to support the NSFW website Recurbate.com, by default the website support 1 free download, so a premium subscription is required

Fixes #

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

@pukkandan pukkandan added site-request Request to support a new website NSFW labels Feb 19, 2023
@Wado729
Copy link

Wado729 commented Mar 23, 2023

I updated both files on my system but when I try recurbate, I get the following error

"ERROR: [generic] None: Unable to download webpage: HTTP Error 403: Forbidden (caused by <HTTPError 403: 'Forbidden'>); please report this issue on https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using yt-dlp -U"

I am using stable@2023.03.04

@mrscrapy
Copy link
Contributor Author

I updated both files on my system but when I try recurbate, I get the following error

"ERROR: [generic] None: Unable to download webpage: HTTP Error 403: Forbidden (caused by <HTTPError 403: 'Forbidden'>); please report this issue on https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using yt-dlp -U"

I am using stable@2023.03.04

Are you sure you have patched yt-dlp correctly?
I'm asking because your error should mention [Recurbate] rather than [generic]

You can use the checkout command to checkout the correct PR gh pr checkout 6297 on your local machine.

Also, do you have a paid membership with Recurbate?
It is required to make this work.

yt_dlp/extractor/recurbate.py Outdated Show resolved Hide resolved
yt_dlp/extractor/recurbate.py Outdated Show resolved Hide resolved
yt_dlp/extractor/recurbate.py Outdated Show resolved Hide resolved
yt_dlp/extractor/recurbate.py Outdated Show resolved Hide resolved
mrscrapy and others added 2 commits March 30, 2023 22:14
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
@mrscrapy
Copy link
Contributor Author

I think they implemented additional cookies validations and now I consistently get 403 while authenticated.
It will probably need some other work

@pukkandan pukkandan force-pushed the master branch 2 times, most recently from ee280c7 to 7aeda6c Compare May 24, 2023 18:09
yt_dlp/extractor/recurbate.py Outdated Show resolved Hide resolved
yt_dlp/extractor/recurbate.py Outdated Show resolved Hide resolved
@pukkandan
Copy link
Member

Pls test nothing's broken.

@pukkandan pukkandan added the needs-testing Patch needs testing label May 29, 2023
@mrscrapy
Copy link
Contributor Author

All good, I added another missing subscription handling

@pukkandan pukkandan removed the needs-testing Patch needs testing label May 31, 2023
@pukkandan pukkandan merged commit c2502cf into yt-dlp:master May 31, 2023
11 checks passed
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NSFW site-request Request to support a new website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants