New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[extractor/medaltv] Fix medal.tv clips URL (#6489) #6502
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xenova
changed the title
Fix medal.tv clips URL
[extractor/medaltv] Fix medal.tv clips URL
Mar 10, 2023
xenova
changed the title
[extractor/medaltv] Fix medal.tv clips URL
[extractor/medaltv] Fix medal.tv clips URL (#6489)
Mar 10, 2023
|
Thanks! |
Should be good now 👍 |
pukkandan
requested changes
Mar 10, 2023
pukkandan
added
site-bug
Issue with a specific website
pending-fixes
PR has had changes requested
labels
Mar 10, 2023
That works 👍 |
aalsuwaidi
pushed a commit
to aalsuwaidi/yt-dlp
that referenced
this pull request
Apr 21, 2024
Closes yt-dlp#6489 Authored by: xenova
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
Medal no longer uses a second API request to get the clip data. Instead, it hydrates the page with the video's data. (Fixes #6489)
NOTE: I have 2 TODOs in my code. I can't quite remember what the yt-dlp way is to get the first item in a dictionary, without knowing it's key:
e.g.,
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?