Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extractor/medaltv] Fix medal.tv clips URL (#6489) #6502

Merged
merged 12 commits into from Mar 12, 2023

Conversation

xenova
Copy link
Contributor

@xenova xenova commented Mar 10, 2023

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Medal no longer uses a second API request to get the clip data. Instead, it hydrates the page with the video's data. (Fixes #6489)

NOTE: I have 2 TODOs in my code. I can't quite remember what the yt-dlp way is to get the first item in a dictionary, without knowing it's key:
e.g.,

"clips":{
    "XEXRelR8Soa7l":{
        ... // <- Actual data here
    }
},
Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

@xenova xenova changed the title Fix medal.tv clips URL [extractor/medaltv] Fix medal.tv clips URL Mar 10, 2023
@xenova xenova changed the title [extractor/medaltv] Fix medal.tv clips URL [extractor/medaltv] Fix medal.tv clips URL (#6489) Mar 10, 2023
@pukkandan
Copy link
Member

pukkandan commented Mar 10, 2023

traverse_obj(clips, ..., get_all=False)
(The ... is literal)

@xenova
Copy link
Contributor Author

xenova commented Mar 10, 2023

traverse_obj(clips, ..., get_all=False)

Thanks!

@xenova xenova marked this pull request as ready for review March 10, 2023 11:27
@xenova
Copy link
Contributor Author

xenova commented Mar 10, 2023

Should be good now 👍

yt_dlp/extractor/medaltv.py Outdated Show resolved Hide resolved
@pukkandan pukkandan added site-bug Issue with a specific website pending-fixes PR has had changes requested labels Mar 10, 2023
@pukkandan pukkandan removed the pending-fixes PR has had changes requested label Mar 10, 2023
@xenova
Copy link
Contributor Author

xenova commented Mar 10, 2023

That works 👍

@xenova xenova requested a review from pukkandan March 10, 2023 16:13
@pukkandan pukkandan merged commit 1e3c2b6 into yt-dlp:master Mar 12, 2023
11 checks passed
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-bug Issue with a specific website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

medal.tv broken for clips URL
2 participants