Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix youku extractor #6690

Merged
merged 5 commits into from Apr 11, 2023
Merged

Fix youku extractor #6690

merged 5 commits into from Apr 11, 2023

Conversation

carusocr
Copy link
Contributor

@carusocr carusocr commented Apr 1, 2023

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Added suggested clean_html change. Also removed several tests that were returning 404s - most seemed redundant with subsequent tests, but couldn't find a replacement for the password-protected URL that was no longer working.

Fixes #6551

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

'tags': list,
},
}, {
'url': 'http://v.youku.com/v_show/id_XNjA1NzA2Njgw.html',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't delete this one since there is no replacement test and just add something like 'skip': '404'

@pukkandan pukkandan added site-enhancement Feature request for some website site-bug Issue with a specific website and removed site-enhancement Feature request for some website labels Apr 1, 2023
@pukkandan pukkandan merged commit ef0848a into yt-dlp:master Apr 11, 2023
11 checks passed
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-bug Issue with a specific website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[youku] HTML in error message
2 participants