Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extractor/iwara] Add access token #6721

Merged
merged 4 commits into from May 11, 2023

Conversation

toomyzoom
Copy link
Contributor

@toomyzoom toomyzoom commented Apr 6, 2023

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Add access token using login info for non private video that is not accessible without account.

Some video would show up as deleted/not exist if not logged in. This is not related to private videos.
If an access token is sent with the http request, the video is accessible. My assumption is those videos are tagged as NSFW/not appropriate for public access.

Fixes #6671

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

@Lesmiscore Lesmiscore linked an issue Apr 24, 2023 that may be closed by this pull request
11 tasks
yt_dlp/extractor/iwara.py Outdated Show resolved Hide resolved
yt_dlp/extractor/iwara.py Outdated Show resolved Hide resolved
yt_dlp/extractor/iwara.py Outdated Show resolved Hide resolved
@user1872372839

This comment was marked as duplicate.

@pukkandan

This comment was marked as resolved.

Copy link
Contributor Author

@toomyzoom toomyzoom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added changes follow reviewers suggestion

Co-authored-by: Lesmiscore <nao20010128@gmail.com>
Copy link
Contributor

@Lesmiscore Lesmiscore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good to merge
Also please do not force-push next time

yt_dlp/extractor/iwara.py Outdated Show resolved Hide resolved
@bobbbob98
Copy link

Anything else need doing with this? I'd like to be able to download these.

@Lesmiscore Lesmiscore merged commit 21b9413 into yt-dlp:master May 11, 2023
11 checks passed
@user1872372839
Copy link

user1872372839 commented Jun 2, 2023

Just an update, ever since today (yesterday it was working perfectly), the login API is not working anymore. If you try to login, all downloads (even those that are not privated/hidden) will fail. It will still work on most of the videos if you remove the username/login, but then private/blocked tags videos will not download.

Example: yt-dlp.exe -f b* --username $userhere --password $passwordhere $downloadlink

Result:
[iwara]: Unable to download JSON metadata: HTTP Error 403: Forbidden (caused by <HTTPError 403: 'Forbidden'>); please report this issue on https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using yt-dlp -U

Using cookies does not work. Using cookies didn't work before either.

@bashonly
Copy link
Member

bashonly commented Jun 2, 2023

@user1872372839 can you open a new issue about this?

@bashonly bashonly added NSFW site-bug Issue with a specific website labels Jun 5, 2023
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NSFW site-bug Issue with a specific website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iwara.tv] Can't download only some videos [Iwara] Unable to access some video without access token
6 participants