[extractor/zoom] Fix share URL extraction #6789
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/share/
URLs need to be redirected before thefile_id
can be extracted, and the redirect URL path comes from an additional API request to theshare-info
endpoint.I had to move some code around, since hypothetically we will want both types of webpages to be checked for password inputs if/when someone manages to fix password-protected video extraction. But otherwise I didn't touch the password validation code.
One thing to note is that the redirect URL/
play
ID returned from theshare-info
endpoint is dynamically generated. No two requests return the same ID (even for the same video). So for the video'sid
, I thought it best to just use whatever ID is in the user-provided URL, regardless of whether it is aplay
ID or ashare
ID.Addresses #6677 (comment)
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?