Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extractor/zoom] Fix share URL extraction #6789

Merged
merged 1 commit into from Apr 13, 2023
Merged

Conversation

bashonly
Copy link
Member

@bashonly bashonly commented Apr 12, 2023

/share/ URLs need to be redirected before the file_id can be extracted, and the redirect URL path comes from an additional API request to the share-info endpoint.

I had to move some code around, since hypothetically we will want both types of webpages to be checked for password inputs if/when someone manages to fix password-protected video extraction. But otherwise I didn't touch the password validation code.

One thing to note is that the redirect URL/play ID returned from the share-info endpoint is dynamically generated. No two requests return the same ID (even for the same video). So for the video's id, I thought it best to just use whatever ID is in the user-provided URL, regardless of whether it is a play ID or a share ID.

Addresses #6677 (comment)

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

@bashonly bashonly added the site-bug Issue with a specific website label Apr 12, 2023
@bashonly bashonly merged commit 90c1f51 into yt-dlp:master Apr 13, 2023
11 checks passed
@bashonly bashonly deleted the fix/zoom branch April 18, 2023 02:46
@dirkf dirkf mentioned this pull request Apr 24, 2023
5 tasks
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-bug Issue with a specific website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant