Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extractor/gronkh] add duration and chapters #6817

Merged
merged 2 commits into from Apr 16, 2023

Conversation

ghost
Copy link

@ghost ghost commented Apr 15, 2023

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Also parse the duration and chapters on gronkh.tv.

Fixes #

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

yt_dlp/extractor/gronkh.py Outdated Show resolved Hide resolved
yt_dlp/extractor/gronkh.py Outdated Show resolved Hide resolved
yt_dlp/extractor/gronkh.py Outdated Show resolved Hide resolved
@bashonly bashonly added site-enhancement Feature request for some website pending-fixes PR has had changes requested labels Apr 15, 2023
@ghost ghost requested a review from bashonly April 15, 2023 15:50
Copy link
Member

@bashonly bashonly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(In the future, please avoid force-pushing during review. Commits will be squashed upon merge, you can commit as needed)

yt_dlp/extractor/gronkh.py Outdated Show resolved Hide resolved
yt_dlp/extractor/gronkh.py Outdated Show resolved Hide resolved
@bashonly bashonly removed the pending-fixes PR has had changes requested label Apr 15, 2023
@bashonly bashonly merged commit 9c92b80 into yt-dlp:master Apr 16, 2023
11 checks passed
@ghost ghost deleted the gronkhchapters branch April 16, 2023 17:29
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-enhancement Feature request for some website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant