[extractor/nhk] Add NHK Radiru (らじる) extractor #6819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
only player page test isn't actually expired at time of writing, but it will eventually
…e ids there are in fact programmes with letters in the id
bashonly
requested changes
Apr 15, 2023
bashonly
added
site-request
Co-Authored-By: bashonly <88596187+bashonly@users.noreply.github.com>
|
oops, didn't check flake8 |
news programmes use their own api and list page, but everything else is still the same format, even the api response the player js hardcodes a special case for that id (F261) too, so this is fine™ it also does one for id F139, but that seems to be dev-only, so i'm not bothering
slightly less deranged way of doing it This commit partially reverts e48a646 Co-Authored-By: bashonly <88596187+bashonly@users.noreply.github.com>
bashonly
approved these changes
Apr 16, 2023
bashonly
reviewed
Apr 16, 2023
Co-Authored-By: bashonly <88596187+bashonly@users.noreply.github.com>
bashonly
reviewed
Apr 19, 2023
bashonly
reviewed
Apr 19, 2023
|
thanks! |
9 tasks
aalsuwaidi
pushed a commit
to aalsuwaidi/yt-dlp
that referenced
this pull request
Apr 21, 2024
* Add `NhkRadioNewsPage` extractor Authored by: garret1317
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
This PR adds support for NHK らじる★らじる, the radio streaming site of Japan's public broadcaster.
It supports downloading individual episodes and entire series (or at least, what's available - the episodes expire eventually), but does not support the live streams.
Downloading entire series sometimes gets episodes that aren't listed on the site, but are still in the API. Example: site listing vs actual download.
I'm unsure whether this is a bug or a feature.
Adding live support is definitely possible - the stream urls are sitting out in the open - but there are regional variations. The region is not reflected in the player url, so I'm not sure how to handle it.
Example URLs (chosen at random)
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?