Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[utils] Fix non-blocking only filesystems #6840

Merged
merged 3 commits into from May 5, 2023
Merged

[utils] Fix non-blocking only filesystems #6840

merged 3 commits into from May 5, 2023

Conversation

Eveldee
Copy link
Contributor

@Eveldee Eveldee commented Apr 17, 2023

This workaround is needed for some filesystems like virtiofs where any file locking or unlocking operation must be non-blocking

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

This PR adds a workaround for the file unlocking operation on some filesystems like virtiofs by adding the UNLOCK_NB flag on error.

Fixes #6823

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Eveldee and others added 3 commits April 17, 2023 11:23
This workaround is needed for some filesystems like virtiofs where any
file locking or unlocking operation must be non-blocking
@brandon-dacrib
Copy link

this fix works for me on using virtiofs with a vm under unraid. I do have a different problem 2023-04-29 18:43:34,875 - sonarr_youtubedl - ERROR - Failed - TBA - Replacement index 1 out of range for positional args tuple but I think it is unrelated.

@pukkandan pukkandan merged commit 45998b3 into yt-dlp:master May 5, 2023
11 checks passed
@Eveldee Eveldee deleted the fix-virtiofs branch May 11, 2023 13:57
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nonblocking file unlock for virtiofs
3 participants