Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extractor/Facebook] fix: Username getting and liveViewerCount #6856

Merged
merged 5 commits into from May 8, 2023

Conversation

ringus1
Copy link
Contributor

@ringus1 ringus1 commented Apr 18, 2023

Description of your pull request and other information

Uploader data is now prioritised to find one with name in it. Falls back to current queries otherwise.
Added optional live_view_count info to metadata too for live videos.

Fixes #3432

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

@ringus1 ringus1 changed the title Adding support for live videos [extractor/Facebook] fix: Username getting and liveViewerCount Apr 18, 2023
@bashonly
Copy link
Member

@bashonly bashonly added site-bug Issue with a specific website pending-fixes PR has had changes requested labels Apr 27, 2023
@ringus1
Copy link
Contributor Author

ringus1 commented Apr 28, 2023

Done, thanks

yt_dlp/extractor/facebook.py Outdated Show resolved Hide resolved
yt_dlp/extractor/facebook.py Outdated Show resolved Hide resolved
yt_dlp/extractor/facebook.py Outdated Show resolved Hide resolved
yt_dlp/extractor/facebook.py Outdated Show resolved Hide resolved
@ringus1 ringus1 requested a review from bashonly May 7, 2023 11:32
yt_dlp/extractor/facebook.py Outdated Show resolved Hide resolved
yt_dlp/extractor/facebook.py Outdated Show resolved Hide resolved
@ringus1 ringus1 requested a review from bashonly May 7, 2023 18:55
@bashonly bashonly removed the pending-fixes PR has had changes requested label May 7, 2023
@bashonly bashonly requested a review from pukkandan May 7, 2023 19:03
@bashonly bashonly merged commit 3b52a60 into yt-dlp:master May 8, 2023
11 checks passed
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-bug Issue with a specific website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Facebook uploader no longer detected
2 participants