Niconico seriesIE no longer working after url update #6898
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically the url format for series pages on niconico changed from just pointing at the series to including the user information in the url. Example:
https://www.nicovideo.jp/series/110226 now redirects to https://www.nicovideo.jp/user/44113208/series/110226
Old urls are still valid through the redirect but the previous extractor's way of extracting the videos is not so that was updated as well.
Also in lieu of adding a specific test for this new url format I just edited one of the old format ones since we had multiple.
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?