Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Niconico seriesIE no longer working after url update #6898

Merged
merged 5 commits into from Apr 25, 2023

Conversation

sqrtNOT
Copy link
Contributor

@sqrtNOT sqrtNOT commented Apr 24, 2023

Basically the url format for series pages on niconico changed from just pointing at the series to including the user information in the url. Example:
https://www.nicovideo.jp/series/110226 now redirects to https://www.nicovideo.jp/user/44113208/series/110226
Old urls are still valid through the redirect but the previous extractor's way of extracting the videos is not so that was updated as well.
Also in lieu of adding a specific test for this new url format I just edited one of the old format ones since we had multiple.

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense

What is the purpose of your pull request?

  • Fix or improvement to an extractor (Make sure to add/update tests)

Lesmiscore added a commit to ytdl-patched/ytdl-patched that referenced this pull request Apr 24, 2023
@sqrtNOT sqrtNOT requested a review from Lesmiscore April 24, 2023 09:55
@sqrtNOT sqrtNOT requested a review from pukkandan April 24, 2023 21:22
Co-authored-by: pukkandan <pukkandan.ytdlp@gmail.com>
@sqrtNOT sqrtNOT requested a review from pukkandan April 25, 2023 09:58
@Lesmiscore Lesmiscore merged commit c86e433 into yt-dlp:master Apr 25, 2023
11 checks passed
@sqrtNOT sqrtNOT deleted the niconico branch May 22, 2023 22:04
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants