[extractors/globalplayer] add Global Player extractors #6903
+261
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bashonly
requested changes
Apr 26, 2023
bashonly
reviewed
Apr 26, 2023
Co-Authored-By: bashonly <88596187+bashonly@users.noreply.github.com>
also one flake8 Co-Authored-By: bashonly <88596187+bashonly@users.noreply.github.com>
bashonly
approved these changes
Apr 26, 2023
bashonly
reviewed
Apr 26, 2023
Co-Authored-By: bashonly <88596187+bashonly@users.noreply.github.com>
pukkandan
requested changes
Apr 26, 2023
bashonly
reviewed
Apr 26, 2023
bashonly
reviewed
Apr 26, 2023
5 tasks
dirkf
added a commit
to dirkf/youtube-dl
that referenced
this pull request
May 3, 2023
* from yt-dlp/yt-dlp#6903, thanks garret1317
dirkf
added a commit
to dirkf/youtube-dl
that referenced
this pull request
May 3, 2023
* from yt-dlp/yt-dlp#6903, thanks garret1317
11 tasks
dirkf
added a commit
to dirkf/youtube-dl
that referenced
this pull request
Jul 18, 2023
* from yt-dlp/yt-dlp#6903, thanks garret1317
dirkf
added a commit
to dirkf/youtube-dl
that referenced
this pull request
Jul 19, 2023
* from yt-dlp/yt-dlp#6903, thanks garret1317
dirkf
added a commit
to dirkf/youtube-dl
that referenced
this pull request
Jul 19, 2023
* from yt-dlp/yt-dlp#6903, thanks garret1317
dirkf
added a commit
to ytdl-org/youtube-dl
that referenced
this pull request
Jul 19, 2023
* from yt-dlp/yt-dlp#6903, thanks garret1317
aalsuwaidi
pushed a commit
to aalsuwaidi/yt-dlp
that referenced
this pull request
Apr 21, 2024
Authored by: garret1317
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
This PR adds support for Global Player, the streaming site for Global Media's radio stations and podcasts. (ironically, Global only operates in the UK*.)
It supports:
I've tried to use
traverse_objmore than in my last PR, as that was one of the main changes made in the code review. I've also added a BaseIE for functions that multiple extractors use, but I may not have done it according to best practices etc - I don't know a lot of python, just enough to be dangerous™.Some of the podcasts have ads. I don't think there's anything I can do about that.
Apparently, you can get higher quality audio with the mobile app. I haven't looked into this, and this PR doesn't implement it.
*the site is not region-locked.
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?