[extractor/twitter] Migrate to GraphQL, handle auth errors #6957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pukkandan
approved these changes
Apr 30, 2023
yt_dlp/extractor/twitter.py
Outdated
|
|
||
| if result.get('errors'): | ||
| errors = traverse_obj(result, ('errors', ..., 'message', {str})) | ||
| if first_attempt and any('bad guest token' in error.lower() for error in errors): |
There was a problem hiding this comment.
Suggested change
| if first_attempt and any('bad guest token' in error.lower() for error in errors): | |
| if first_attempt and not self.is_logged_in and any('bad guest token' in error.lower() for error in errors): |
correct? Otherwise it may unnecessarily try twice when logged in.
There was a problem hiding this comment.
it wouldn't hurt to add, but I don't think it's necessary as we are already never passing a guest token when logged in
EDIT: ended up refactoring the error handling and adding it
aalsuwaidi
pushed a commit
to aalsuwaidi/yt-dlp
that referenced
this pull request
Apr 21, 2024
Closes yt-dlp#6763 Authored by: bashonly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometime in early April, Twitter changed something and broke our age-gate bypass for sensitive media. We had been using a "deprecated" bearer token to get around the age-restriction, which has now been rendered effectively useless. And because the legacy API (that we were using by default for tweet extraction) only returns a 404 without any further info for age-restricted tweets, this site change has necessitated that tweet extraction defaults to the GraphQL API instead, since GraphQL returns error info that can be used to detect when to
raise_login_required.The change in default behavior makes the
force_graphqlextractor-arg pointless, so this PR replaces it with thelegacy_apiextractor-arg, which has the opposite effect, and could be used as a fallback in case of potential future GraphQL breakage. Also, the legacy API is still used by other subclasses, so legacy API code cannot be removed/replaced entirely.Closes #6763
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?