Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ie/Qub] Fix extractor #7019

Merged
merged 3 commits into from
May 8, 2024
Merged

[ie/Qub] Fix extractor #7019

merged 3 commits into from
May 8, 2024

Conversation

alexhuot1
Copy link
Contributor

@alexhuot1 alexhuot1 commented May 9, 2023

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Fixes the 404 error on tva/qub website. Used the fix proposed in the youtube-dl issue: ytdl-org/youtube-dl#31240

Fixes #
#4989

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

What is the purpose of your pull request?

@pukkandan
Copy link
Member

The code is not following our style requirements, but youtube-dl's. Either wait for it to be merged upstream and I will pull it. Or, rewrite according to our conventions.

@pukkandan pukkandan added the patch-available There is patch available that should fix this issue. Someone needs to make a PR with it label May 9, 2023
@pukkandan pukkandan force-pushed the master branch 2 times, most recently from ee280c7 to 7aeda6c Compare May 24, 2023 18:09
@pukkandan pukkandan added pending-fixes PR has had changes requested stale-pr PR that has been pending fixes for a long time labels May 29, 2023
@pukkandan pukkandan added the site-bug Issue with a specific website label Jun 21, 2023
@dnlldl
Copy link

dnlldl commented Sep 13, 2023

The code is not following our style requirements, but youtube-dl's. Either wait for it to be merged upstream and I will pull it. Or, rewrite according to our conventions.

Any update? It still doesn't work as of now with the latest release.

@bashonly bashonly self-requested a review September 17, 2023 01:05
yt_dlp/extractor/tva.py Outdated Show resolved Hide resolved
yt_dlp/extractor/tva.py Outdated Show resolved Hide resolved
yt_dlp/extractor/tva.py Outdated Show resolved Hide resolved
yt_dlp/extractor/tva.py Outdated Show resolved Hide resolved
@bashonly bashonly removed the stale-pr PR that has been pending fixes for a long time label Sep 17, 2023
@seproDev seproDev added the stale-pr PR that has been pending fixes for a long time label Nov 4, 2023
@alexhuot1
Copy link
Contributor Author

I've adjusted the PR to be more precise. Thanks ;)

@alexhuot1 alexhuot1 requested a review from bashonly April 30, 2024 14:39
@pukkandan pukkandan removed stale-pr PR that has been pending fixes for a long time pending-fixes PR has had changes requested labels May 1, 2024
@alexhuot1 alexhuot1 closed this May 8, 2024
@alexhuot1 alexhuot1 reopened this May 8, 2024
Copy link
Member

@bashonly bashonly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update the test

@bashonly bashonly changed the title Fixes tva.py extractor [ie/Qub] Fix extractor May 8, 2024
@bashonly bashonly removed the patch-available There is patch available that should fix this issue. Someone needs to make a PR with it label May 8, 2024
@bashonly bashonly merged commit 6b54ccc into yt-dlp:master May 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-bug Issue with a specific website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants