-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ie/Qub] Fix extractor #7019
[ie/Qub] Fix extractor #7019
Conversation
The code is not following our style requirements, but youtube-dl's. Either wait for it to be merged upstream and I will pull it. Or, rewrite according to our conventions. |
ee280c7
to
7aeda6c
Compare
Any update? It still doesn't work as of now with the latest release. |
I've adjusted the PR to be more precise. Thanks ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please update the test
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
Fixes the 404 error on tva/qub website. Used the fix proposed in the youtube-dl issue: ytdl-org/youtube-dl#31240
Fixes #
#4989
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
Took the code from this repo: https://github.com/dirkf/youtube-dl
This file exactly: https://github.com/dirkf/youtube-dl/blob/df-tva-extractor-ovrhaul/youtube_dl/extractor/tva.py
What is the purpose of your pull request?