Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cam FM catch up extractors #7083

Merged
merged 7 commits into from May 29, 2023
Merged

Add Cam FM catch up extractors #7083

merged 7 commits into from May 29, 2023

Conversation

garret1317
Copy link
Collaborator

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

This PR adds support for Cam FM, Cambridge and Anglia Ruskin University's student radio station.

It doesn't support the live stream. Generic extractor works alright enough™ (plays in mpv), and there's not really anything to extract anyway

I added a new date format in utils.py to make unified_timestamp work.

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

generic extractor is adequate enough for live, so not bothering with that for now
added a new date format to make unified_timestamp work
yt_dlp/extractor/camfm.py Outdated Show resolved Hide resolved
yt_dlp/extractor/camfm.py Outdated Show resolved Hide resolved
yt_dlp/extractor/camfm.py Outdated Show resolved Hide resolved
yt_dlp/extractor/camfm.py Outdated Show resolved Hide resolved
yt_dlp/extractor/camfm.py Outdated Show resolved Hide resolved
yt_dlp/extractor/camfm.py Outdated Show resolved Hide resolved
yt_dlp/extractor/camfm.py Outdated Show resolved Hide resolved
yt_dlp/extractor/camfm.py Outdated Show resolved Hide resolved
yt_dlp/utils.py Outdated Show resolved Hide resolved
@pukkandan pukkandan added site-request Request to support a new website pending-fixes PR has had changes requested labels May 22, 2023
garret1317 and others added 3 commits May 22, 2023 16:38
Co-Authored-By: pukkandan <pukkandan.ytdlp@gmail.com>
Co-Authored-By: bashonly <88596187+bashonly@users.noreply.github.com>
@garret1317
Copy link
Collaborator Author

per #7083 (comment), have refined the regexes by mostly replacing them with get_element(s)_by_class

@pukkandan pukkandan removed the pending-fixes PR has had changes requested label May 24, 2023
@pukkandan pukkandan force-pushed the master branch 2 times, most recently from ee280c7 to 7aeda6c Compare May 24, 2023 18:09
@pukkandan pukkandan merged commit 4cbfa57 into yt-dlp:master May 29, 2023
11 checks passed
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-request Request to support a new website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants