6720: Pressing enter uses default format

[ivanskodje]

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Original Issue Description:

Using -f- prompts "Enter format selector:"
When entering nothing (i.e. just pressing Enter) outputs "ERROR: Requested format is not available"

It would be more helpful in this case to autoselect the default format (i.e. the format which would have been selected
by not using the -f switch at all) instead of asking again (which doesn't make too much sense IMO).

• Pressing enter will use default format.
• Updated the wording of the message

Fixes #6720

PLEASE FOLLOW THE GUIDE BELOW

• You will be asked some questions, please read them carefully and answer honestly
• Put an x into all the boxes [ ] relevant to your pull request (like [x])
• Use Preview tab to see how your pull request will actually look like

-->

Before submitting a pull request make sure you have:

• At least skimmed through contributing guidelines including yt-dlp coding conventions
• Searched the bugtracker for similar pull requests
• Checked the code with flake8 and ran relevant tests

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

• I am the original author of this code and I am willing to release it under Unlicense
• I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

• Fix or improvement to an extractor (Make sure to add/update tests)
• New extractor (Piracy websites will not be accepted)
• Core bug fix/improvement
• New feature (It is strongly recommended to open an issue first)

Copilot Summary

🤖 Generated by Copilot at 7239233

Summary

🆕🎛️📝

Add default format spec option and debug message to interactive format selection mode in yt_dlp/YoutubeDL.py

format selection
press ENTER or CTRL+C
autumn leaves falling

Walkthrough

• Add a feature to the interactive format selection mode that allows using the default format spec or quitting with keyboard shortcuts (link)
• Display a debug message with the default format spec used in the interactive mode (link)

[pukkandan]

Let me know what you think of the changes

[ivanskodje]

Let me know what you think of the changes

Moving of the format_selector is None looks fine, but the req_format change makes the code more difficult to read and understand.

Easy to read and understand:

req_format = input(self._format_screen('\nEnter format selector (press ENTER for default, or CTRL+C to quit): ', self.Styles.EMPHASIS))

Not so easy to read and understand:

req_format = input(' '.join((
                    self._format_screen('\nEnter format selector', self.Styles.EMPHASIS),
                    '(Press ENTER for default, or Ctrl+C to quit)',
                    self._format_screen(': ', self.Styles.EMPHASIS))
                ))

Does using join on an empty string with a space, and using two _format_screen() give benefits in Python that I am not aware of?

If the line was too long, we could separate the long text into a helper variable, but it was probably is fine the way it was.

prompt = '\nEnter format selector (press ENTER for default, or CTRL+C to quit): '
req_format = input(self._format_screen(prompt, self.Styles.EMPHASIS))

[Grub4K]

Take note that we are applying emphasis to just the parts that are not in the braces. We deliberately use str.join to take emphasis away from the braced part. I think the hanging brace should go into the above line though

[ivanskodje]

Take note that we are applying emphasis to just the parts that are not in the braces. We deliberately use str.join to take emphasis away from the braced part. I think the hanging brace should go into the above line though

I am afraid I do not understand what you mean by "(...) take emphasis away from the braced part". Could you elaborate on what you mean? Is this a specific coding convention, or is there a functional purpose to this?

I agree regarding hanging brace, I recall reading the contribution docs about that avoiding hanging paranthesis. 👍

[Grub4K]

We are calling self._format_screen() on only '\nEnter format selector' and ': ', making them bold. The braced part will be left regular. The line will render as

Enter format selector (Press ENTER for default, or Ctrl+C to quit) : _

I think we should go one further and use ''.join instead since I also don't like the space after the brace (to quit) : ), thinking about it now

[ivanskodje]

Excellent feedback!
Did some cleanup, now the text should look the way we want it too 🤞

[Grub4K]

Extracting the emphasis into a function is overkill. Having to write the style to format with does not make it more unreadable imo. If thats reverted it LGTM

[ivanskodje]

Extracting the emphasis into a function is overkill. Having to write the style to format with does not make it more unreadable imo. If thats reverted it LGTM

While I appreciate your viewpoint and will duly revert the changes, I have a suggestion that could enhance our coding practices moving forward.

To maintain a clean codebase and ensure easier code maintenance, I propose we adopt a strategy of separating concerns (YoutubeDL.py appears to do a little of everything). Specifically, we could introduce a dedicated class and corresponding functions to manage formatting tasks. This approach would mitigate the reliance on a multipurpose function, which can potentially augment complexity and demand a higher level of knowledge for utilization.

In the context of the function in question, its use cases appear to be quite limited, with only two observable uses: one involving FILENAME, and a few instances with self.Styles.EMPHASIS. These observations further endorse the implementation of dedicated functions for each distinct task. 😺

[Grub4K]

Thats already semi in progress. There are two big networking PRs, partially getting merged bit by bit into the codebase, there is #5680 doing the formatting and output separation. It just takes time and is a chore since the reworks are big and reviews take time, and we need to keep compat (somewhat) on the side...